[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support |
Date: |
Mon, 04 Aug 2008 20:01:37 +0200 |
User-agent: |
Thunderbird 2.0.0.14 (X11/20080501) |
Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <address@hidden> wrote:
>> - allow xenpv machines run without disk and kernel specified
>> by adding a nodisk_ok field to QEMUMachine.
>
> Nice idea, this would be a useful feature by itself.
Yes, some embedded devices probably can use that too according to the
source code comment. Guess thats why anthony suggested to do it that
way, and I liked the idea too, so I just did ;)
>> + $(XEN_OBJS) : CFLAGS += -Wall -Wmissing-prototypes -Wstrict-prototypes
>
> These aren't needed for Xen. Though I wonder why at least -Wall
> -Wstrict-prototypes could not be added globally.
IIRC I tried to turn them on globally and found myself swamped with
warnings. So I took the easy way out and enabled them only for the xen
bits I'm working on. I like those warnings, they catch sloppyness and
help writing clean code. They are in no way required though. We can
add them globally nevertheless, I can keep them as local patch, I don't
mind much.
>> + if (-1 != xen_present)
>
> This style looks alien to me. Do you really find it readable?
Bad habit. gcc warns these days on "if (foo = 42)", so the reason to
write "if (42 = foo)" is gone. I'm still doing that for -- say --
historical reasons?
cheers,
Gerd
--
http://kraxel.fedorapeople.org/xenner/
- [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Gerd Hoffmann, 2008/08/04
- [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support, Gerd Hoffmann, 2008/08/04
- [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Blue Swirl, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Samuel Thibault, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Anthony Liguori, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Paul Brook, 2008/08/04
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Gerd Hoffmann, 2008/08/05
- Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., Blue Swirl, 2008/08/04