|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH v2] Fix compilation of nbd on Windows |
Date: | Sun, 03 Aug 2008 15:42:18 -0500 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
Johannes Schindelin wrote:
Hi,[was it intentional that you culled me, and me alone, from the Cc: list? I know that you like to be rude against me, but I'd like to know if it was really meant this way this time.]
No, it's the annoying way that the mailing list is configured. The mailing list sets a Reply-To header and reply to all in thunderbird ignores the original From line (because Reply-To has been set).
It is not the definition, but just the declaration.
The problem is mixing a static and non-static declaration of a function.
And by your own reasoning, it should not be in vl.c but in qemu_socket.h,
Yup.
where I would have picked up on it and spared myself writing my own implementation of inet_aton().Indeed, it seems that inet_aton() is defined in slirp/misc.c. So qemu_socket.h is not even the right place for the definition, but better than nothing.
Ugh, I wonder what happens when you do --disable-slirp :-( Do you want to work up a patch to sanitize all of this or should I?
Regards, Anthony Liguori
Ciao, Dscho
[Prev in Thread] | Current Thread | [Next in Thread] |