[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [REMINDER] Re: target-sh4/op.c:597: warning: cast to pointe
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [REMINDER] Re: target-sh4/op.c:597: warning: cast to pointer from integer of different size |
Date: |
Sun, 13 Jul 2008 14:32:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Jan Kiszka wrote:
> The warning above pointed me to some strange code. I guess this was
> originally indented:
>
> Signed-off-by: Jan Kiszka <address@hidden>
>
> Index: qemu/target-sh4/op.c
> ===================================================================
> --- qemu.orig/target-sh4/op.c
> +++ qemu/target-sh4/op.c
> @@ -594,8 +594,8 @@ void OPPROTO op_shlr16_Rn(void)
>
> void OPPROTO op_tasb_rN(void)
> {
> - cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
> - *(int8_t *) env->gregs[PARAM1] |= 0x80;
> + cond_t((env->gregs[PARAM1] & 0xff) == 0);
> + *(int8_t *) &env->gregs[PARAM1] |= 0x80;
> RETURN();
> }
>
Problem still exists, patch still applies - does anyone take care of
this arch?
Jan
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [REMINDER] Re: target-sh4/op.c:597: warning: cast to pointer from integer of different size,
Jan Kiszka <=