[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [RESEND][PATCH] save/restore interrupt_request acro
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Re: [RESEND][PATCH] save/restore interrupt_request across snapshots |
Date: |
Tue, 1 Jul 2008 22:55:00 +0100 |
User-agent: |
KMail/1.9.9 |
On Tuesday 01 July 2008, Jan Kiszka wrote:
> Paul Brook wrote:
> >> Save interrupt_request state along with the cpu snapshot and restore it
> >> properly. This also solves the bug that pending interrupts before
> >> invocation of qemu_loadvm_state can tunnel into the resumed guest,
> >> causing invalid IRQs there.
> >
> > I just checked in a patch which is a superset of this functionality.
>
> Nice cleanups!
>
> ( Well, except for
>
> if (version_id != 3 && version_id != 4 && version_id != 5
> && version_id != 6)
>
> :-> )
I was tempted to rip it out altogether, and replace with
if (version_id != CPU_SAVE_VERSION)
IMHO explicitly enumerating all the versions we claim to be able to load isn't
a bad thing.
> And after fixing this typo, it also works nicely:
> qemu_get_be32s(f, &env->halted);
> - qemu_put_be32s(f, &env->interrupt_request);
> + qemu_get_be32s(f, &env->interrupt_request);
Good catch, thanks.
Paul