[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] buffer overruns in qemu-system-sparc (hw/eccmemctl.c: e
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] buffer overruns in qemu-system-sparc (hw/eccmemctl.c: ecc_reset()) |
Date: |
Wed, 18 Jun 2008 00:37:32 +0100 |
User-agent: |
KMail/1.9.9 |
On Tuesday 17 June 2008, Julian Seward wrote:
> + int four = sizeof(s->regs[0]);
You're joking, right?
Either you know the value and you should use an actual number "4", or it might
not be 4, and you should call the variable something sensible.
Either way It should not be a modifiable variable.
Paul