qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows passing


From: Ian Jackson
Subject: Re: [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows passing of an argument
Date: Fri, 13 Jun 2008 10:20:49 +0100

Anthony Liguori writes ("Re: [Qemu-devel] [PATCH] New scriptarg=... -net 
parameter allows passing of an argument"):
> Avi Kivity wrote:
> > Environment variables are global, whereas scriptarg is per-interface.  
> > Consider the case where scriptarg denotes the bridge name we want the 
> > interface to attach to.
...
> It's nicer IMHO because it extends well to passing more data to the 
> script (like whatever the -name parameter is).

I agree that all of the parameters to -net ought to be passed as
environment variables.

> I was originally going to suggest arbitrary ,key=value be passed by 
> default as environmental variables like QEMU_key=value but I think that 
> would get too complicated given the current code.

I think there's no particular reason why the current tap structure
couldn't be augmented by a linked list.  I'd be happy to make a patch
to do that.

Ian.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]