Re: [Qemu-devel] [PATCH] Proposed fix broken RST response to a slirp redirect socket

[Edgar E. Iglesias]

On Wed, Jun 11, 2008 at 03:10:35PM -0500, Jason Wessel wrote:
> +                     int err;
> +                     socklen_t slen;
> +
> +                     err = errno;
> 
> ---
> 
> Probably don't need to set err to errno since you are collecting it with 
> getsockopt

Please note that the errno value is used when nn < 0.

> 
> ---
> 
> +                     if (nn == 0)
> +                             getsockopt(so->s, SOL_SOCKET, SO_ERROR,
> +                                        &err, &slen);
> 
> ---
> 
> In theory you are supposed to set slen = sizeof(err);  prior to calling 
> getsockopt()

Thanks, I'll fix that up.
 
Best regards
-- 
Edgar E. Iglesias
Axis Communications AB