[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] New qemu-img convert -B option to preserve the
From: |
Jamie Lokier |
Subject: |
Re: [Qemu-devel] [PATCH] New qemu-img convert -B option to preserve the COW aspect of images and/or re-base them |
Date: |
Tue, 3 Jun 2008 21:43:13 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Anthony Liguori wrote:
> It's sloppy. In general, using a non-portable feature for no good
> reason other than you can is bad practice (even if we do depend on GCC).
It's 2008, the standard is called C99 for a reason.
In 1998, we would have used C89 constructs like function prototypes,
wouldn't we?
:-)
If you don't want to use non-portable features, may I suggest
"gcc -std=c89".
(Half joking, I use -Wdeclaration-after-statement myself to catch
this, since it became a standard GCC feature with no option to turn it
off and keep other GNU extensions. But then, I write code which is
more portable than QEMU and target older architectures.)
-- Jamie