[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch] Make qemu-nbd compile on OS X
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [patch] Make qemu-nbd compile on OS X |
Date: |
Mon, 2 Jun 2008 18:54:17 +0100 |
User-agent: |
Mutt/1.4.1i |
On Mon, Jun 02, 2008 at 11:44:17AM -0600, C.W. Betts wrote:
> The following is a patch to make qemu-nbd compile on Mac OS X Leopard
> (any other versions are untested)
>
> Index: qemu-nbd.c
> ===================================================================
> --- qemu-nbd.c (revision 4654)
> +++ qemu-nbd.c (working copy)
> @@ -21,7 +21,11 @@
> #include "block_int.h"
> #include "nbd.h"
>
> +#ifdef __APPLE__
> +#include <malloc/malloc.h>
> +#else
> #include <malloc.h>
> +#endif
The include of malloc.h looks rather bogus to me. malloc() is part
of stdlib.h, and is not even used in this file anyway. It compiles fine
on Linux if you remove include of malloc.h entirely
Regards,
Daniel.
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|