Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec

[Blue Swirl]

On 5/27/08, Paul Brook <address@hidden> wrote:
> > +void cpu_load_flags(CPUState *env);
>  > +void cpu_put_flags(CPUState *env);
>
>
> These really need a comment saying what they do. The names are not at all
>  intuitive. Also, why load/put? I'd expect load/save/store or get/put.
>
>
>  > +#if defined(reg_REGWPTR)
>  > +static uint32_t *saved_regwptr;
>  > +#endif
>
>
> Eww. You've replaced reasonably self contained local code with a global
>  variable hidden deep in target specific code. I plan on adding multithreaded
>  qemu support soon, so this is a non-starter.

REGWPTR code can be removed, it's not used now.