qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_D


From: Kevin Wolf
Subject: Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_DIRECT)
Date: Wed, 21 May 2008 10:06:38 +0200
User-agent: Thunderbird 2.0.0.12 (X11/20071114)

Anthony Liguori schrieb:
That's a problem with the current patch honestly, we should not rely on callers to align buffers. bdrv_read()/bdrv_aio_read()/bdrv_pread() all should be tolerant of unaligned buffers if we're going to support O_DIRECT.

I agree, we shouldn't rely on that. And actually we don't. ;-)

If (buf & 0x1ff) we're using the emulation with our own aligned buffer. Without this "tolerance" my test image wouldn't even boot up.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]