[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] serial save load fix
From: |
andrzej zaborowski |
Subject: |
Re: [Qemu-devel] [PATCH] serial save load fix |
Date: |
Sat, 17 May 2008 20:36:17 +0200 |
On 15/05/2008, Ben Guthro <address@hidden> wrote:
> This patch fixes several bugs in serial.c
> (1) No support provided in serial_load() for version_id == 1 (should
> unmarshal
> a 1 byte s->divider and should provide a default value for s->fcr
> (2) Call serial_ioport_write() to initialize s->fcr. It is not sufficient
> to load its value; other hidden values (such as s->recv_fifo.itl) must be
> re-initialized.
The patch does apply (other than it has to be de-HTML-ised) but
version 2 of serial_load doesn't save the FCR, at least in the SVN
tree,
http://svn.savannah.gnu.org/viewvc/trunk/hw/serial.c?revision=4336&root=qemu&view=markup
Please check.
Cheers
--
Please do not print this email unless absolutely necessary. Spread
environmental awareness.