Re: [Qemu-devel] Compilation broken in SVN version and a debug register question

[Ben Taylor]

On Sun, May 4, 2008 at 3:45 PM, Aurelien Jarno <address@hidden> wrote:
> Ben Taylor a écrit :
>
> > On Sun, May 4, 2008 at 1:29 PM, Brad Campbell <address@hidden> wrote:
>  >> Ben Taylor wrote:
>  >>
>  >>> On Wed, Apr 23, 2008 at 8:34 AM, Balazs Attila-Mihaly (Cd-MaN)
>  >>> <address@hidden> wrote:
>  >>>
>  >>>> Hello all.
>  >>>>
>  >>>>  I fail to compile the version 4242 from the SVN (which I checked out ~1
>  >> hour ago). On an Ubuntu 7.10 host with gcc-3.4 and ./configure
>  >> --target-list=i386-softmmu, I get the following error:
>  >>>>
>  >>  <snip>
>  >>
>  >>
>  >>
>  >>> The following patch should fix the compilation of op.c and helper.c.
>  >>>
>  >>> This been tested on solaris x86 (32/64 bit) and Ubuntu 7.10 (32-bit).
>  >> When
>  >>> configuring on the 32-bit systems, I used --extra-cflags="-march=i686
>  >>> -mtune=i686"
>  >>> and both spill errors in op.c and helper.c are gone, and the binaries
>  >>> will boot Milax (a Solaris based DamnSmallLinux clone)
>  >>>
>  >>  On ubuntu...
>  >>  apt-get remove gcc-3.4
>  >>  apt-get install gcc-3.3
>  >>  .. effectively worked around the issue for me.
>  >
>  > Tried that, but one of the maintainers thought that was not a reasonable
>  > solution.
>
>  I also think this is a reasonable solution. Hardcoding the use of
>  gcc-3.3 in the Makefile is not.
>
>
>
>  > I suppose I can modify the patch to check to see which gcc is being used
>  > any invoke those changes if gcc revision < 3.4

I have another patch in to works that checks the gcc3 revision and appropriately
applies the flags.  As it turns out, -march and -mtune are not recognized by
gcc-3.3 anyway, so it'll be a better solution.  If I can figure out why it's not
working on Solaris and not Ubuntu, I'll submit.

Ben