Re: [Qemu-devel] [PATCH] ncurses: resize console if required

[andrzej zaborowski]

On 28/04/2008, Carlo Marcelo Arenas Belon <address@hidden> wrote:
> On Mon, Apr 28, 2008 at 11:14:15AM +0100, Thiemo Seufer wrote:
>  > Carlo Marcelo Arenas Belon wrote:
>  > > The following patch instructs qemu to print an escape command to resize 
> the
>  > > curses console to 80x25 if detected to have a different geometry (xterm 
> and
>  > > friends use 80x24 by default).
>  >
>  > Sounds like this should be specific to the PC/VGA emulation.
>
>
> not sure what you mean, but the curses.c emulation assumes (and is hardcoded)
>  to a 80x25 console anyway.

It's only this way because SDL uses 640x400, but it can change when
the vga starts living.  For example the text mode ms windows installer
(80x43 or something) worked fine for me with -curses.

>
>  this patch only checks the window size of the console that is being used and
>  sends it an escape command to change its size to what the curses console will
>  use so that they match; otherwise if starting qemu from an 80x24 xterm with
>  -curses you won't be able to see the last line of the console until the 
> window
>  is resized.

To be honest I wasn't aware that there's a sequence to request
terminal size change.  "man console_codes" on my system doesn't list
this sequence and also it doesn't seem to have any effect in
gnome-terminal.  This backend however is the curses backend, not
terminal backend and even if the sequence worked, we should only use
what curses can provide (this means that we don't even need a unix
terminal).  It seems that curses generally wants programs to be aware
of the terminal size and conform, rather than have any say.  So that
would be a policy change also.

Regards
-- 
Please do not print this email unless absolutely necessary. Spread
environmental awareness.