Re: [Qemu-devel] [4261] Errors while registering ioports are not fatal (Glauber Costa).

[Anthony Liguori]

Paul Brook wrote:
> On Saturday 26 April 2008, Andrzej Zaborowski wrote:
>   
> > Revision: 4261
> >           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4261
> > Author:   balrog
> > Date:     2008-04-26 16:04:29 +0000 (Sat, 26 Apr 2008)
> >
> > Log Message:
> > -----------
> > Errors while registering ioports are not fatal (Glauber Costa).
> >     
>
> Why shouldn't they be fatal? How can this be anything other than a serious bug 
> in the device emulation?
>   

I think the idea is that the device should fail to initialize rather the 
VM being destroyed.  Consider the case of PCI hotplug.  It's a 
recoverable error if register ioport fails during hot add.

In general, it's better to avoid exit()'ing deep in the code and instead 
propagate errors.  With that said, I don't think we should just 
eliminate the hw_error() call without going through and updating all the 
callers of register_ioport to handle that function failing.

Regards,

Anthony Liguori

> Paul
>
>
>