[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer

From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size.
Date: Fri, 28 Mar 2008 17:22:30 +0100
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

On Fri, Mar 28, 2008 at 11:35:52AM +0000, Ian Jackson wrote:
> Aurelien Jarno writes ("Re: [Qemu-devel] [PATCH] Improve DMA transfers by 
> increasing the buffer size."):
> > On Wed, Mar 26, 2008 at 04:35:00PM +0000, Ian Jackson wrote:
> > Content-Description: message body text
> > > +#define IDE_DMA_BUF_SIZE 131072
> > 
> > Wouldn't it be better to define this value in number of sectors? This
> > would avoid a few divisions in the code, and anyway the code handling
> > DMA transfers is working with a number of sectors, not a number of 
> > bytes.
> I don't have much of an opinion about what units it should be in.  The
> divisions are just at compile-time of course.

I agree that the generated assembly code should not be different, but
this makes the code less readable.

> If you prefer I'll send another version with it done in sectors :-).

Please send it, I will commit it. 

  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net

reply via email to

[Prev in Thread] Current Thread [Next in Thread]