Re: [Qemu-devel] [PATCH] Windows: put version and file info into exe

[Johannes Schindelin]

Hi,

On Thu, 7 Feb 2008, C.W. Betts wrote:

> This patch will make an .rc file that will put the version info as well 
> as a brief discription of the app for Windows.

It would have been easier to comment on the patch if you would have 
inlined it.

>diff -u -r1.187 configure
>--- configure   3 Feb 2008 19:20:13 -0000       1.187
>+++ configure   7 Feb 2008 18:11:27 -0000
>@@ -677,7 +677,7 @@
>
> if test "$mingw32" = "yes" ; then
>   if test -z "$prefix" ; then
>-      prefix="/c/Program Files/Qemu"
>+      prefix=/c/Program\ Files/Qemu
>   fi
>   mansuffix=""
>   datasuffix=""

Why not go the full nine yards and use $PROGRAMFILES, being nice to 
non-English users?  Besides, how is this change related to your subject?  
Is it even necessary?

>+echo "   VALUE \"LegalCopyright\", \"GNU Lesser General Public 
>License\"" >> $version_rc

This is actively wrong: LICENSE states

        1) QEMU as a whole is released under the GNU General Public 
        License

>+#echo "   VALUE \"ProductVersion\", \"@address@hidden"" > $version_rc

You don't want that to be committed.

Overall: would it not be nicer to have the version.rc file tracked, 
instead of written by configure?  You'd only need to add a #define for 
the WINDOWS_VERSION (a la QEMU_VERSION) in config-host.h.  Then use it in 
version.rc.  TARGET_ARCH is already #defined in $target/config.h, and for 
the OriginalFilename, you could change the Makefile rule from

+
+%.o: %.rc
+       windres  -c -o $< $@

to

+
+%.o: %.rc
+       windres -DORIGINAL_FILENAME=\"$(QEMU_PROG)\" -c -o $< $@

Hth,
Dscho