Re: [Qemu-devel] [PATCH 1/5] Fix i386 Host

[Johannes Schindelin]

Hi,

On Fri, 18 Jan 2008, Alexander Graf wrote:

> On Jan 18, 2008, at 4:41 PM, Fabrice Bellard wrote:
> 
> > Alexander Graf wrote:
> > > This patch is mostly a cleanup of Michael Matz's patch with the 
> > > ideas that came last time included.
> > 
> > I must say I don't like such patches because they are likely to break 
> > with every new GCC version.
> 
> Basically these patches only fixed what was broken, so I don't see any 
> way they make anything worse than what we have now. Especially because 
> the only intrusive patches are the i386 ones, which are conditional for 
> gcc4, so there really is nothing it breaks here. It merely removes the 
> assumption that if registers can be used for temporary variables, there 
> are 3 spare ones and fixes a bug which was officially marked as XXX.

But that broke a previously working system, and that's why I agree with 
Fabrice.

Ciao,
Dscho