Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

[Laurent Vivier]

Le jeudi 10 janvier 2008 à 11:53 +0000, Johannes Schindelin a écrit :
> Hi,
> 
> On Thu, 10 Jan 2008, Laurent Vivier wrote:
> 
> > Le mercredi 09 janvier 2008 à 13:27 +0000, Johannes Schindelin a écrit :
> > [...]
> > > Besides, it would not be _that_ complicated:
> > 
> > This patch doesn't manage the case where we have comma in filename:
> > 
> > qemu -drive file=my,file,if=scsi
> > 
> > where filename is "my,file".
> 
> Right.  But then, my patch only tried to undo the regression.
> 
> As for the "my,file" problem: you _could_ change the parser so that it 
> picks up on "-drive if=scsi,file=my,file" having no "=" after the last 
> comma, but that does not help the case where a file name contains both a 
> comma and an equal sign.

Perhaps the best solution is to put "file=" option at the end of
aliases, '\0' is marking the end of filename (it is likely the idea of
andrzej about special characters).
For the case where user uses directly "-drive" perhaps we can just
explain in the doc he must put "file=" at the of the parameter when he
must use ' ', ',','"' or '=': 

qemu -drive if=scsi,bus=0,unit=6,file="my scsi disk.img" -hda "my ide0
disk.img"

(in this case quotes are managed by the shell)

It should ever work.

Regards,
Laurent
-- 
----------------- address@hidden  ------------------
  "La perfection est atteinte non quand il ne reste rien à
ajouter mais quand il ne reste rien à enlever." Saint Exupéry

signature.asc
Description: Ceci est une partie de message numériquement signée