qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables


From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines
Date: Fri, 07 Dec 2007 15:24:38 -0600
User-agent: Thunderbird 2.0.0.6 (X11/20071022)

Ryan Harper wrote:
* Anthony Liguori <address@hidden> [2007-12-07 15:07]:
Ryan Harper wrote:
* Anthony Liguori <address@hidden> [2007-12-07 14:49]:
+
+CPUState *first_cpu;

This should probably be static.
doh, should be extern actually since it's defined elsewhere.
Perhaps you want cpu_single_env instead of first_cpu?

I wasn't quite sure given the comments surrounding its declaration:

from exec.c:

CPUState *first_cpu;
/* current CPU in the current thread. It is only valid inside
      cpu_exec() */
CPUState *cpu_single_env;

Yeah, I guess since you build this at init time, first_cpu is more appropriate.

Regards,

Anthony Liguori






reply via email to

[Prev in Thread] Current Thread [Next in Thread]