Re: [Qemu-devel] qemu vl.c hw/omap.c

[Laurent Vivier]

Le mardi 04 décembre 2007 à 01:20 +0000, Paul Brook a écrit :
> On Tuesday 04 December 2007, andrzej zaborowski wrote:
> > On 04/12/2007, Paul Brook <address@hidden> wrote:
> > > > Log message:
> > > >       Always create an SD bdrv, so that PXA and OMAP boards can boot
> > > > with no card inserted again.  Eventually SD, CDROM and floppy should
> > > > all be registered conditionally depending on machine.
> > >
> > > This seems the wrong way to solve this problem. The SD emulation should
> > > be able to cope with no device being present.
> >
> > The bdrv's represent the concept of "drive" rather than "media", and
> > also in the case the bdrv must be present whenever there is a SD slot,
> > not an SD card (so that monitor command change and eject can be used).
> > I agree that not all machines have an SD slot, as not all machines
> > have a cd-rom drive or floppy drive.
> 
> Right, but I think you're going in the wrong direction. Most scsi interfaces 
> do support hotplug of devices. For USB mass storage the whole controller is 
> hotplug. Pre-allocating all possible devices simply doesn't scale.

Hi Paul,

I think Andrzez is doing it correctly.

He only adds an entry in drives_table[] without creating any bdrv
(because he doesn't provide file).
Then in omap.c, he creates the device, not the media. And as Palm
Tunsgten is the only machine calling omap310_mpu_init(), the device is
only created for it. And then he will be able to introduce card (file)
in the SD reader.

Laurent
-- 
------------- address@hidden  --------------
       "Any sufficiently advanced technology is
  indistinguishable from magic." - Arthur C. Clarke

signature.asc
Description: Ceci est une partie de message numériquement signée