Re: [Qemu-devel] qemu block-vvfat.c block.c console.c dyngen.c e...

[Thiemo Seufer]

Igor Kovalenko wrote:
> On Nov 18, 2007 4:44 AM, Paul Brook <address@hidden> wrote:
> > CVSROOT:        /sources/qemu
> > Module name:    qemu
> > Changes by:     Paul Brook <pbrook>     07/11/18 01:44:38
> >
> > Modified files:
> >         .              : block-vvfat.c block.c console.c dyngen.c
> >                          elf_ops.h i386-dis.c loader.c monitor.c osdep.c
> >                          qemu-char.h translate-op.c usb-linux.c vl.c
> >                          vnc.c x_keymap.c
> >         audio          : audio.c
> >         hw             : arm_sysctl.c arm_timer.c gt64xxx.c i8259.c
> >                          ide.c mc146818rtc.c mcf_fec.c mips_malta.c
> >                          ne2000.c nvram.h omap.c omap.h omap_lcdc.c
> >                          parallel.c pc.c pci.c pckbd.c piix_pci.c
> >                          pl061.c pl190.c pxa2xx_lcd.c pxa2xx_pcmcia.c
> >                          realview_gic.c rtl8139.c sd.c sh_serial.c
> >                          sh_timer.c smbus.c stellaris.c usb-ohci.c
> >                          wm8750.c
> >         target-i386    : helper.c
> >
> > Log message:
> >         Add statics and missing #includes for prototypes.
> >
> 
> Here is a patch to hw/rtl8139.c which makes it reuse eeprom
> implementation available in eeprom93xx.

Introduces some warnings. I figure reading the eeprom contents back
is done incorrectly.

/home/ths/qemu/qemu-work/hw/rtl8139.c: In function `rtl8139_load':
/home/ths/qemu/qemu-work/hw/rtl8139.c:3072: warning: passing arg 2 of 
`qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3073: warning: passing arg 2 of 
`qemu_get_be16s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3074: warning: passing arg 2 of 
`qemu_get_be16s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3076: warning: passing arg 2 of 
`qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3077: warning: passing arg 2 of 
`qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3078: warning: passing arg 2 of 
`qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3079: warning: passing arg 2 of 
`qemu_get_8s' from incompatible pointer type
/home/ths/qemu/qemu-work/hw/rtl8139.c:3063: warning: unused variable 
`eeprom_contents'


Thiemo