Re: [Qemu-devel] qemu/target-ppc op_helper.c

[Aurelien Jarno]

On Mon, Oct 29, 2007 at 10:21:26PM +0100, J. Mayer wrote:
> 
> On Mon, 2007-10-29 at 22:12 +0100, Aurelien Jarno wrote:
> > > CVSROOT:        /sources/qemu
> > > Module name:    qemu
> > > Changes by:     Jocelyn Mayer <j_mayer> 07/10/27 17:59:46
> > > 
> > > Modified files:
> > >        target-ppc     : op_helper.c 
> > > 
> > > Log message:
> > >         PowerPC float bugfix: 64 bits float mantissa is 52 bits long.
> > > 
> > > CVSWeb URLs:
> > > http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.55&r2=1.56
> > 
> > 
> > I know that it looks strange, but this commit breaks perl. The function 
> > mkdir(dir, mode) sometimes does not set the mode correctly. This can be
> > easily reproduce on Debian by using "dpkg-source -x file.dsc", which
> > fails due to wrong permission.
> > 
> > I am using qemu-system-ppc -M prep -cpu G3
> 
> Thanks for the report !
> Could you please try replacing the 0x3FF mask with 0x7FF ? As the
> exponent is supposed to be 11 bits, my patch is obviously still buggy...
> I noticed there was a bug somewhere, but was not convinced it was in the
> FPU emulation... Now ...
> 

Yep that fixes the problem. Thanks a lot!

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net