Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom

[Daniel P. Berrange]

On Mon, Oct 29, 2007 at 03:49:18PM +0100, andrzej zaborowski wrote:
> On 29/10/2007, Daniel P. Berrange <address@hidden> wrote:
> > On Sun, Oct 28, 2007 at 11:43:33PM +0100, address@hidden wrote:
> > > From: Laurent Vivier <address@hidden(none)>
> > >
> > > This patch allows to define where is connected the CDROM device (bus,
> > > unit).
> > > It extends the "-cdrom" syntax to add these paramaters:
> > >
> > >      -cdrom file[,if=type][,bus=n][,unit=m]
> > >
> > >  where "type" defines the interface (by default, "ide")
> > >        "n" defines the bus number (by default 1)
> > >        "m" defines the unit number (by default 0)
> >
> >
> > Having a separately named arg just for CDROMs was always rather 
> > odd/unhelpful.
> > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc 
> > unchanged
> > and use the -disk for setting up all types of disks, floppys, cdroms, etc. 
> > It
> > would just require one extra field for the -disk arg:
> 
> Sounds logical and I thought this was the plan. I also wouldn't mind
> having -sda, -sdb... following the intuitive naming based on linux
> /dev, but IIRC there were some people on the list who didn't like this
> idea. (I know /dev/sda doesn't have to be an SCSI disk on some recent
> systems, but it's still the most intuitive name for most users).

Adding more -sda arguments is just asking for trouble. On recent Fedora,
even IDE disks will end up as /dev/sdNNN named devices. So what happens
when you have -hda & -sda at same time.... pain & suffering is what 
happens :-) Avoiding device names as args by just using -disk is nicer

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|