Re: [Qemu-devel] Proposal for host-utils

[Thiemo Seufer]

J. Mayer wrote:
> 
> On Sun, 2007-10-28 at 00:53 +0200, J. Mayer wrote:
> > Following the previous discussions about host-utils implementations,
> > here's a patch with the following changes:
> > - move mulu64 and muls64 definitions from exec.h to host-utils.h, for
> > consistency
> > - include host-utils.h in more files to reflect this change
> > - make the optimized version of mulu64 / muls64 for amd64 hosts static
> > inline
> > - change clz64 to avoid 64 bits logical operations to optimize the 32
> > bits host case
> > - add ctz32, ctz64, cto32 and cto64, using the same method than ctlzxx /
> > cloxx implementations
> > - add ctpop8, ctpop16, ctpop32 and ctpop64, using the Sparc target
> > implementation method
> >   ctpop8 is used by the PowerPC target, I added ctpop16 for consistency
> > - change the Alpha and the PowerPC targets to use those helpers
> 
> I did commit the ctz, cto and ctpop helpers. I have a remaining patch
> that contains the changes for mulu64 / muls64 and optimize clz64 and
> clo64, avoiding 64 bits values manipulation, which may help when running
> on a 32 bits host.
> 
> Please comment.

I like it.


Thiemo