Re: [Qemu-devel] [RFC, PATCH] Support for loading 32 bit ELF files for 64 bit linux-user

[J. Mayer]

On Sun, 2007-10-07 at 20:07 +0300, Blue Swirl wrote:
> On 10/7/07, Thiemo Seufer <address@hidden> wrote:
> > Blue Swirl wrote:
> > [snip]
> > > Index: qemu/linux-user/qemu.h
> > > ===================================================================
> > > --- qemu.orig/linux-user/qemu.h       2007-10-07 10:50:05.000000000 +0000
> > > +++ qemu/linux-user/qemu.h    2007-10-07 10:51:09.000000000 +0000
> > > @@ -33,6 +33,7 @@
> > >          target_ulong    data_offset;
> > >          char            **host_argv;
> > >       int             personality;
> > > +        int             is_64bits;
> > >  };
> >
> > I think the 64bit-ness should be part of the personality. In the end,
> > we need a notion of the ABI in use, not just a specific cpu feature flag.
> 
> Good point. I've updated the patch to use the personality field
> instead, for that I updated the personality stuff.

Well done !
I really like this new version as it is far less intrusive. And I guess
it can quite easily be used by other 64 bits targets.

-- 
J. Mayer <address@hidden>
Never organized