Re: [Qemu-devel] [Bug] Timer bugs in hw/m48t59.c?

[J. Mayer]

On Mon, 2007-09-24 at 19:24 +0200, Stefan Weil wrote:
> Hello,

Hi,

> the bug mentioned in my previous mail is still open.
> Could someone please add the patch to CVS HEAD
> (or find another solution)?

Seems you're right, this code would lead to crashes. I think there are
other issues to address in the same code because alrm_timer and wd_timer
are always NULL if the RTC model is a m48t08.
Could you please take a look at this updated patch ?

Regards.

> 
> Thank you
> Stefan
> 
> Stefan Weil schrieb:
> > Hi,
> >
> > could SPARC or PPC users please check whether the timer code
> > in hw/m48t59.c is really correct?
> >
> > I expect a crash in qemu_mod_timer after wd_timer = NULL and
> > a call to qemu_mod_timer with this NULL value.
> >
> > The same applies to alrm_timer.
> >
> > I wrote a quick-and-dirty patch, but think that even more
> > old code could be removed.
> >
> > Stefan
> >
[...]

-- 
J. Mayer <address@hidden>
Never organized

m48t59.c.diff
Description: Text Data