[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Updated RFC: linux user problems]]
From: |
Jocelyn Mayer |
Subject: |
Re: [Qemu-devel] Updated RFC: linux user problems]] |
Date: |
Mon, 24 Sep 2007 20:27:54 +0200 |
On Mon, 2007-09-24 at 13:19 +0100, Thiemo Seufer wrote:
> J. Mayer wrote:
> [snip]
> > > > > May someone take a look at my patch and say if it seems reasonable to
> > > > > include this in the repository ?
> > > >
> > > > Looks reasonable, but introduces new compiler warnings
> > > > (on a ppc32/Linux host):
> >
> > The reported warnings have been fixed.
> > There are still a lot of warnings related to 32/64 bits invalid casts on
> > 64 bits hosts (see above) which will need to be fixed once.
> >
> > I also changed some parameters of do_ipc from long to int (instead of
> > target_long), following the do_ipc man page specification, and reported
> > this change in child functions. There may be more to do...
> >
> > Please comment...
>
> Fine with me, FWIW.
Great. I may do another pass, to check all helpers against long/int
confusion to avoid using target_ulong when not necessary.
I would appreciate anyone who would test the patch on other platforms
than x86 / PowerPC, as I would like not to break everything...