Re: [Qemu-devel] [PATCH] SVM support

[Thiemo Seufer]

Alexander Graf wrote:
> Thiemo Seufer wrote:
> > Alexander Graf wrote:
> >   
> >> Thanks to Michael Peter who tried the patch on an x86 host I found some
> >> compilation problems.
> >> This updated patch addresses these issues and thus should compile on
> >> every platform for every target available.
> >>     
> >
> > Tried that on PPC/Linux:
> >
> > libqemu.a(cpu-exec.o): In function cpu_x86_exec':
> > /home/ths/qemu/qemu-work/cpu-exec.c:439: undefined reference to ldl_phys'
> > /home/ths/qemu/qemu-work/cpu-exec.c:439: undefined reference to stl_phys'
> > /home/ths/qemu/qemu-work/cpu-exec.c:440: undefined reference to ldl_phys'
> > libqemu.a(op.o): In function op_svm_check_intercept_io':
> > /home/ths/qemu/qemu-work/target-i386/op.c:1282: undefined reference to 
> > stq_phys'
> > libqemu.a(translate-op.o): In function dyngen_code':
> > /home/ths/qemu/qemu-work/i386-linux-user/./op.h:4101: undefined reference 
> > to stq_phys'
> > /home/ths/qemu/qemu-work/i386-linux-user/./op.h:4101: undefined reference 
> > to stq_phys'
> > collect2: ld returned 1 exit status
> > make[1]: *** [qemu-i386] Error 1
> > make: *** [subdir-i386-linux-user] Error 2
> >
> >
> > Thiemo
> >
> >
> >   
> Wow sorry about that, looks like I missed these.

I worked a bit on the patch to remove some coding style issues and data
type mismatches which caused compiler warnings. The result is attached
and seems to work reasonably well for me.

That said, J. Mayers comments point out worthwile improvements, so I
don't commit it for now. Please incorporate my changes in your patch,
and look into improving it further.


Thiemo

svm.patch
Description: Text Data