[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [kvm-devel] [PATCH] Dynamic ticks
|
From: |
Dan Kenigsberg |
|
Subject: |
[Qemu-devel] Re: [kvm-devel] [PATCH] Dynamic ticks |
|
Date: |
Thu, 16 Aug 2007 12:36:15 +0300 |
|
User-agent: |
Mutt/1.5.14 (2007-02-12) |
Luca,
One more comment on your patch: the logic in the following condition
does not fit the comment bellow it.
On Mon, Aug 13, 2007 at 10:37:41PM +0200, Luca Tettamanti wrote:
> + if (use_dynamic_ticks() && dynticks_create_timer()) {
> + /* dynticks disabled or failed to create a timer, fallback
> + * to old code.
> + */
> + [old code follows]
One should have
if (!use_dynamic_ticks() || dynticks_create_timer()) {
Instead.
Regards,
Dan.