[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu Makefile configure
From: |
Bernhard Fischer |
Subject: |
Re: [Qemu-devel] qemu Makefile configure |
Date: |
Wed, 3 Jan 2007 17:58:23 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Wed, Jan 03, 2007 at 04:16:53PM +0000, Thiemo Seufer wrote:
>Fabrice Bellard wrote:
>> IMHO, CFLAGS and LDFLAGS overriding should not be allowed for QEMU as it
>> is almost sure to break the dyngen stuff. If ever it is allowed, it
>> should be done so that the CFLAGS for the files used by dyngen are not
>> modified.
>
>That's why I made OP_CFLAGS a separate set of flags.
>
>I append the next version of the patch, which incorporates the
>suggestions made by Daniel and Bernhard, and fixes a gcc3 detection
>bug I introduced earlier.
Is the override directive a common extension?
http://www.opengroup.org/onlinepubs/009695399/utilities/make.html
I'd avoid override if possible and use a different variable instead
(CC_CFLAGS, or the like) to be passed to the .c.o rules