Re: [Qemu-devel] Large USB-Patch Documentation and todays CVS patch

[Lonnie Mendez]

Johannes Schindelin wrote:

> I am quite sure you put a lot of work into this patch, but you sure make it
> hard to appreciate, too.
>
> First note that applying such a huge patch is bad. Let me help you (a little
> more than last time) to understand that: You are almost guaranteed to
> introduce bugs, and what's worse, regressions. Because it is so huge, you
> are further guaranteed to have a real hard time tracking that regression.
>  
  Seeing as there is a release coming up this is most definitely not a 
good thing.  Initial testing yielded lots of this. 

  I'd like to see my all-in-one patch stripped out.  Then simply 
modifying the linux redirector to support the improved error handling 
(have it clear endpoint halt/etc) and other improvements.  Later, the 
new redirectors can be merged in and modified as necessary.

  The purpose of modifying the user interface to the usb layer also 
confuses me.  What was the reasoning behind changing host:busaddr.addr 
to host:busaddr:addr and host:VID:PID to host:VIDxPID?  This is 
something that should be abstracted in the layer and not handed down to 
the user.  Why display the bcdUSB revision and not the connected speed 
to the user (as is already done)?

  To argue that this must all go in at once or none at all is silly.  
I've seen the changes and know that my redirectors aren't necessary for 
this to function.  I'm not trying to get anyone down on this but am just 
saying this needs more discussion and thought.