[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] Minor mips-related patchlet
Date: Sat, 11 Mar 2006 15:01:05 +0000
User-agent: KMail/1.9.1

> Index: target-mips/op_mem.c
> +extern void dump_sc (void);

Having function prototypes in .c files is wrong. I added it to exec.h instead.

> +void glue(op_store_T2_gpr_gpr, REG) (void)
> +{
> +    env->gpr[REG] = T2;
> +    RETURN();
> +}

I don't think there's any point adding this unless it's actually used. The ARM 
target doesn't have this op either.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]