Re: [Qemu-devel] [PATCH] qemu-0.7.0 Solaris Host patch (Real)

[Alex Beregszaszi]

Hi,

> Please ignore the first post. A webmail annomally sent
> the message before it was cooked. :-)
> 
> This patch is mostly a collation of several sets of Solaris
> host patches that have been around.  Thanks to Juergen
> and a few others for actually having done the hard work
> of debugging and making things work.

I just noticed in the block.c code that it uses pread and pwrite all
around the code, which, at least the man page states, reads from an
offset specified. While it does that, you still left the lseek there. Is
that for a reason? And why are you using pread instead the good old
read?

Imho if pread is faster, there should be an USE_PREAD macro, which would
be set true on Solaris, while making the use of it for other systems
possible.

-- 
Alex Beregszaszi                        e-mail: address@hidden
Free Software Network                   cell: +36 70 3144424