[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] fix interaction with noexecstack

From: Fabrice Bellard
Subject: Re: [Qemu-devel] Re: [PATCH] fix interaction with noexecstack
Date: Wed, 29 Sep 2004 23:23:00 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624

Applied with some modifications.


Filip Navara wrote:
Ronald wrote:

Tested, need to include <winbase.h> (and <windows.h>).
gcc juste produce a warning with VirtualProtect:
/home/ronald/Prog/Win32/combo/qemu/exec.c: Dans la fonction « page_init »:
/home/ronald/Prog/Win32/combo/qemu/exec.c:155: AVERTISSEMENT: passage de
arg 1 de « VirtualProtect » transforme en pointeur un entier sans

aproximative translation: in function page_init passing arg1 of
VirtualProtect is making pointer from integer without a cast.
Thanks much for testing it, now I got a minute to test it on my box. The attach patch adds the #include, fixes the warning and also dynamicly detects the page size. These changes are actually needed when running QEMU on WinXP SP2 on AMD64. I'm quite not happy with the (original) patch yet, because it uses "unsigned long" for storing pointer and this will *break any 64-bit build* on non-Windows platforms. It would be nice if someone can solve it.

(My only hope is that the MinGW build of QEMU will not be broken...)


Note: with **VirtualProtect or *VirtualProtect make is aborting, I have
used VirtualProtect.
Sorry, my mail client messed that up

reply via email to

[Prev in Thread] Current Thread [Next in Thread]