[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] DOSEMU image file support

From: Fabrice Bellard
Subject: Re: [Qemu-devel] [PATCH] DOSEMU image file support
Date: Thu, 02 Sep 2004 19:12:09 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803

Hampa Hug wrote:
Fabrice Bellard wrote:

Thank you for the patch. Two remarks if you want that I merge it:

1) use open/read/write/close instead of fopen/fread/fwrite/fclose for consistency with other block drivers.

The reason I used stdio is that read/write are non-blocking. It is
not an error for read to return fewer bytes than requested. If that
happens, the other block drivers fail.

I agree, but for disk accesses it is usual to assume they return the requested amount of bytes. fread/fwrite are buffered I/Os which is a bit overkill for block drivers.

2) change the license to BSD

I was under the impression that we used GPL. At least that's what

The different parts of QEMU have different licenses (and of course it affects the license of the resulting program). As mentionned on the web page:

- The QEMU virtual CPU core library is released under the GNU Lesser General Public License.
- The Linux QEMU emulator is released under the GNU General Public License.
- The QEMU PC system emulator is released under the MIT/BSD License.

The block layer belongs to the QEMU PC system emulator, so its license is BSD.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]