Re: [Qemu-devel] WinXP mouse patch

[Mike Nordell]

Mark Jonckheere wrote:

> The following patch against the latest CVS (13 april) resolved
> for me the slow mouse movements in WinXP.

Looking at it, I see difference between hosts and do one observation.

The difference is that QEMU on Win32 isn't as far as I have observed or
experienced plagued by this problem. The observation is that if SDL did its
job, this patch would be "dead code" - a code path never taken, why it seems
to me to be an SDL problem/bug related to your specific host OS. Could you
verify this?

I base that observation on the fact that kbd_mouse_event() should only be
called from sdl_send_mouse_event() in sdl.c, which in turn should only be
called when an SDL event of type SDL_MOUSEMOTION, SDL_MOUSEBUTTONDOWN or
SDL_MOUSEBUTTONUP is recieved. If you get SDL_MOUSEMOTION with with dx&dy =
0 from SDL_GetRelativeMouseState, I can't see any other explanation than an
SDL problem.


That said, since it apparently solves a real problem I too think the patch
should be included, with the addition of a comment explaining why that code
is there.


/Mike