qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 977485: gdbstub/internals.h: clean up include


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 977485: gdbstub/internals.h: clean up include guard
Date: Thu, 09 Mar 2023 13:50:14 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9774855842b392e49dd14a048ebb24cbfe0d3be9
      
https://github.com/qemu/qemu/commit/9774855842b392e49dd14a048ebb24cbfe0d3be9
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/internals.h

  Log Message:
  -----------
  gdbstub/internals.h: clean up include guard

Use something more specific to avoid name clashes.

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-2-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-2-richard.henderson@linaro.org>


  Commit: 9455762f58823e106a9fc7c10413a05455731bb3
      
https://github.com/qemu/qemu/commit/9455762f58823e106a9fc7c10413a05455731bb3
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/softmmu.c
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: fix-up copyright and license files

When I started splitting gdbstub apart I was a little too boilerplate
with my file headers. Fix up to carry over Fabrice's copyright and the
LGPL license header.

Fixes: ae7467b1ac (gdbstub: move breakpoint logic to accel ops)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-3-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-3-richard.henderson@linaro.org>


  Commit: 1c4517b8b68cdb0965559a39922220e7aeb4acf2
      
https://github.com/qemu/qemu/commit/1c4517b8b68cdb0965559a39922220e7aeb4acf2
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M include/exec/gdbstub.h

  Log Message:
  -----------
  gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs

Prototypes using gdb_syscall_complete_cb() or gdb_?et_reg_cb()
don't depend on "cpu.h", thus are not target-specific.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20221214143659.62133-1-philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-4-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-4-richard.henderson@linaro.org>


  Commit: ad9e4585b3c7425759d3eea697afbca71d2c2082
      
https://github.com/qemu/qemu/commit/ad9e4585b3c7425759d3eea697afbca71d2c2082
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c

  Log Message:
  -----------
  gdbstub: clean-up indent on gdb_exit

Otherwise checkpatch will throw a hissy fit on the later patches that
split this function up.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Message-Id: <20230302190846.2593720-5-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-5-richard.henderson@linaro.org>


  Commit: 8e70c6f947d4ee6894085943a333456e575ddd1f
      
https://github.com/qemu/qemu/commit/8e70c6f947d4ee6894085943a333456e575ddd1f
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c

  Log Message:
  -----------
  gdbstub: define separate user/system structures

In preparation for moving user/softmmu specific bits from the main
gdbstub file we need to separate the connection details into a
user/softmmu state. As these will eventually be defined in their own
files we move them out of the common GDBState structure.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-6-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-6-richard.henderson@linaro.org>


  Commit: 9f56787c12e1b5f594ca790b1d84b8cc43a962d3
      
https://github.com/qemu/qemu/commit/9f56787c12e1b5f594ca790b1d84b8cc43a962d3
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h

  Log Message:
  -----------
  gdbstub: move GDBState to shared internals header

We are about to split softmmu and user mode helpers into different
files. To facilitate this we will need to share access to the GDBState
between those files.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-7-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-7-richard.henderson@linaro.org>


  Commit: 548c96095dae2af37c4145ff11f0d010c43e2be2
      
https://github.com/qemu/qemu/commit/548c96095dae2af37c4145ff11f0d010c43e2be2
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M MAINTAINERS
    M accel/stubs/tcg-stub.c
    M accel/tcg/tb-maint.c
    M accel/tcg/translate-all.c
    M cpu.c
    M gdbstub/gdbstub.c
    M hw/ppc/spapr_hcall.c
    M include/exec/exec-all.h
    A include/exec/tb-flush.h
    M linux-user/user-internals.h
    M plugins/core.c
    M plugins/loader.c
    M target/alpha/sys_helper.c
    M target/riscv/csr.c

  Log Message:
  -----------
  includes: move tb_flush into its own header

This aids subsystems (like gdbstub) that want to trigger a flush
without pulling target specific headers.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-8-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-8-richard.henderson@linaro.org>


  Commit: 1678ea040e5d4a4cd613a4af18d776fb2397f0a8
      
https://github.com/qemu/qemu/commit/1678ea040e5d4a4cd613a4af18d776fb2397f0a8
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h

  Log Message:
  -----------
  gdbstub: move fromhex/tohex routines to internals

These will be needed from multiple places in the code. They are
declared as inline so move to the header and fix up to modern coding
style.

The only other place that messes with hex stuff at the moment is the
URI handling in utils but that would be more code churn so leave for
now.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-9-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-9-richard.henderson@linaro.org>


  Commit: 36e067b2f28892afd91d319b89350d4753ef82af
      
https://github.com/qemu/qemu/commit/36e067b2f28892afd91d319b89350d4753ef82af
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h

  Log Message:
  -----------
  gdbstub: make various helpers visible to the rest of the module

We will be needing to use these helpers between the user and softmmu
files so declare them in the headers, add a system prefix and remove
static from the implementations.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-10-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-10-richard.henderson@linaro.org>


  Commit: b6fa2ec238e48d0bfba618011ec154867e386587
      
https://github.com/qemu/qemu/commit/b6fa2ec238e48d0bfba618011ec154867e386587
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/softmmu.c
    M gdbstub/trace-events

  Log Message:
  -----------
  gdbstub: move chunk of softmmu functionality to own file

This is mostly code motion but a number of things needed to be done
for this minimal patch set:

  - move shared structures to internals.h
  - splitting some functions into user and softmmu versions
  - fixing a few casting issues to keep softmmu common

More CONFIG_USER_ONLY stuff will be handled in a following patches.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-11-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-11-richard.henderson@linaro.org>


  Commit: d96bf49ba842e8e1b73c7884d2be084582f34228
      
https://github.com/qemu/qemu/commit/d96bf49ba842e8e1b73c7884d2be084582f34228
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M MAINTAINERS
    M bsd-user/main.c
    M bsd-user/signal.c
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/meson.build
    M gdbstub/softmmu.c
    A gdbstub/user-target.c
    M gdbstub/user.c
    M include/exec/gdbstub.h
    A include/gdbstub/user.h
    M linux-user/main.c
    M linux-user/signal.c

  Log Message:
  -----------
  gdbstub: move chunks of user code into own files

The process was pretty similar to the softmmu move except we take the
time to split stuff between user.c and user-target.c to avoid as much
target specific compilation as possible. We also start to make use of
our shiny new header scheme so the user-only helpers can be included
without the rest of the exec/gsbstub.h cruft.

As before we split some functions into user and softmmu versions

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-12-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-12-richard.henderson@linaro.org>


  Commit: ccd4c7c24a722288127eff2a4dc2793e6a3c04f0
      
https://github.com/qemu/qemu/commit/ccd4c7c24a722288127eff2a4dc2793e6a3c04f0
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/softmmu.c

  Log Message:
  -----------
  gdbstub: rationalise signal mapping in softmmu

We don't really need a table for mapping two symbols.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-13-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-13-richard.henderson@linaro.org>


  Commit: a7e0f9bd2ace16df2aa557b0670c20bfe9cef280
      
https://github.com/qemu/qemu/commit/a7e0f9bd2ace16df2aa557b0670c20bfe9cef280
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/softmmu.c
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: abstract target specific details from gdb_put_packet_binary

We unfortunately handle the checking of packet acknowledgement
differently for user and softmmu modes. Abstract the user mode stuff
behind gdb_got_immediate_ack with a stub for softmmu.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-14-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-14-richard.henderson@linaro.org>


  Commit: 8a2025b36b4f7a20f1bbbcf52d9d6c10094ffd49
      
https://github.com/qemu/qemu/commit/8a2025b36b4f7a20f1bbbcf52d9d6c10094ffd49
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/softmmu.c
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: specialise handle_query_attached

In both user and softmmu cases we are just replying with a constant.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-15-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-15-richard.henderson@linaro.org>


  Commit: 589a58672e044c0415e70f018393c8406cdd5c49
      
https://github.com/qemu/qemu/commit/589a58672e044c0415e70f018393c8406cdd5c49
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/softmmu.c
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: specialise target_memory_rw_debug

The two implementations are different enough to encourage having a
specialisation and we can move some of the softmmu only stuff out of
gdbstub.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-16-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-16-richard.henderson@linaro.org>


  Commit: 7ea0c33deffbbfc6b378f51503139aaa036322d6
      
https://github.com/qemu/qemu/commit/7ea0c33deffbbfc6b378f51503139aaa036322d6
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/softmmu.c
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: introduce gdb_get_max_cpus

This is needed for handling vcont packets as the way of calculating
max cpus vhanges between user and softmmu mode.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-17-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-17-richard.henderson@linaro.org>


  Commit: 505601d5806a5b9a8acde140da5b507bdd03a794
      
https://github.com/qemu/qemu/commit/505601d5806a5b9a8acde140da5b507bdd03a794
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/softmmu.c
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: specialise stub_can_reverse

Currently we only support replay for softmmu mode so it is a constant
false for user-mode.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-18-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-18-richard.henderson@linaro.org>


  Commit: b428ad12341fe0d8ec936942dca65dd4bc5a7ba5
      
https://github.com/qemu/qemu/commit/b428ad12341fe0d8ec936942dca65dd4bc5a7ba5
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c

  Log Message:
  -----------
  gdbstub: fix address type of gdb_set_cpu_pc

The underlying call uses vaddr and the comms API uses unsigned long
long which will always fit. We don't need to deal in target_ulong
here.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-19-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-19-richard.henderson@linaro.org>


  Commit: 379b42e8b7681ebea45cde4af8ffd1694f98949d
      
https://github.com/qemu/qemu/commit/379b42e8b7681ebea45cde4af8ffd1694f98949d
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c

  Log Message:
  -----------
  gdbstub: don't use target_ulong while handling registers

This is a hangover from the original code. addr is misleading as it is
only really a register id. While len will never exceed
MAX_PACKET_LENGTH I've used size_t as that is what strlen returns.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-20-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-20-richard.henderson@linaro.org>


  Commit: 4ea5fe997db4c5d893b69072f488880c07857a54
      
https://github.com/qemu/qemu/commit/4ea5fe997db4c5d893b69072f488880c07857a54
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M include/exec/gdbstub.h
    A include/gdbstub/helpers.h
    M semihosting/syscalls.c
    M target/alpha/gdbstub.c
    M target/arm/gdbstub.c
    M target/arm/gdbstub64.c
    M target/arm/tcg/helper-a64.c
    M target/arm/tcg/m_helper.c
    M target/avr/gdbstub.c
    M target/cris/gdbstub.c
    M target/hexagon/gdbstub.c
    M target/hppa/gdbstub.c
    M target/i386/gdbstub.c
    M target/i386/whpx/whpx-all.c
    M target/loongarch/gdbstub.c
    M target/m68k/gdbstub.c
    M target/m68k/helper.c
    M target/m68k/m68k-semi.c
    M target/microblaze/gdbstub.c
    M target/mips/gdbstub.c
    M target/mips/tcg/sysemu/mips-semi.c
    M target/nios2/cpu.c
    M target/nios2/nios2-semi.c
    M target/openrisc/gdbstub.c
    M target/openrisc/interrupt.c
    M target/openrisc/mmu.c
    M target/ppc/cpu_init.c
    M target/ppc/gdbstub.c
    M target/riscv/gdbstub.c
    M target/rx/gdbstub.c
    M target/s390x/gdbstub.c
    M target/s390x/helper.c
    M target/sh4/gdbstub.c
    M target/sparc/gdbstub.c
    M target/tricore/gdbstub.c
    M target/xtensa/core-dc232b.c
    M target/xtensa/core-dc233c.c
    M target/xtensa/core-de212.c
    M target/xtensa/core-de233_fpu.c
    M target/xtensa/core-dsp3400.c
    M target/xtensa/core-fsf.c
    M target/xtensa/core-lx106.c
    M target/xtensa/core-sample_controller.c
    M target/xtensa/core-test_kc705_be.c
    M target/xtensa/core-test_mmuhifi_c3.c
    M target/xtensa/gdbstub.c
    M target/xtensa/helper.c
    M target/xtensa/import_core.sh

  Log Message:
  -----------
  gdbstub: move register helpers into standalone include

These inline helpers are all used by target specific code so move them
out of the general header so we don't needlessly pollute the rest of
the API with target specific stuff.

Note we have to include cpu.h in semihosting as it was relying on a
side effect before.

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-21-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-21-richard.henderson@linaro.org>


  Commit: c566080cd37fe328077a3c49d7fd248ce2a06bfe
      
https://github.com/qemu/qemu/commit/c566080cd37fe328077a3c49d7fd248ce2a06bfe
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M bsd-user/freebsd/os-syscall.c
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/meson.build
    M gdbstub/softmmu.c
    A gdbstub/syscalls.c
    M gdbstub/user.c
    M include/exec/gdbstub.h
    A include/gdbstub/syscalls.h
    M linux-user/exit.c
    M semihosting/arm-compat-semi.c
    M semihosting/guestfd.c
    M semihosting/syscalls.c
    M softmmu/runstate.c
    M target/m68k/m68k-semi.c
    M target/mips/tcg/sysemu/mips-semi.c
    M target/nios2/nios2-semi.c

  Log Message:
  -----------
  gdbstub: move syscall handling to new file

Our GDB syscall support is the last chunk of code that needs target
specific support so move it to a new file. We take the opportunity to
move the syscall state into its own singleton instance and add in a
few helpers for the main gdbstub to interact with the module.

I also moved the gdb_exit() declaration into syscalls.h as it feels
pretty related and most of the callers of it treat it as such.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-22-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-22-richard.henderson@linaro.org>


  Commit: 61b2e136db5a628cadcb4a1a5c68efbab4c8e2fb
      
https://github.com/qemu/qemu/commit/61b2e136db5a628cadcb4a1a5c68efbab4c8e2fb
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/meson.build

  Log Message:
  -----------
  gdbstub: only compile gdbstub twice for whole build

Now we have removed any target specific bits from the core gdbstub
code we only need to build it twice. We have to jump a few meson hoops
to manually define the CONFIG_USER_ONLY symbol but it seems to work.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-23-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-23-richard.henderson@linaro.org>


  Commit: bcbc36a98fe84e19c972bac19dd94aaf3a06a628
      
https://github.com/qemu/qemu/commit/bcbc36a98fe84e19c972bac19dd94aaf3a06a628
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M MAINTAINERS
    M configure
    A scripts/probe-gdb-support.py
    M tests/tcg/aarch64/Makefile.target
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/multiarch/system/Makefile.softmmu-target
    M tests/tcg/s390x/Makefile.target

  Log Message:
  -----------
  testing: probe gdb for supported architectures ahead of time

Currently when we encounter a gdb that is old or not built with
multiarch in mind we fail rather messily. Try and improve the
situation by probing ahead of time and setting
HOST_GDB_SUPPORTS_ARCH=y in the relevant tcg configs. We can then skip
and give a more meaningful message if we don't run the test.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230302190846.2593720-24-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-24-richard.henderson@linaro.org>


  Commit: 4692a86f1c90a26cad752409fc8d30e591e1f741
      
https://github.com/qemu/qemu/commit/4692a86f1c90a26cad752409fc8d30e591e1f741
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M MAINTAINERS
    M include/exec/cpu-defs.h
    A include/exec/target_long.h

  Log Message:
  -----------
  include: split target_long definition from cpu-defs

While we will continue to include this via cpu-defs it is useful to be
able to define this separately for 32 and 64 bit versions of an
otherwise target independent compilation unit.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-25-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-25-richard.henderson@linaro.org>


  Commit: 131f387d741ee2dfe953f8829e5634e49e6dfb31
      
https://github.com/qemu/qemu/commit/131f387d741ee2dfe953f8829e5634e49e6dfb31
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/internals.h
    M gdbstub/softmmu.c
    M gdbstub/syscalls.c
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: split out softmmu/user specifics for syscall handling

Most of the syscall code is config agnostic aside from the size of
target_ulong. In preparation for the next patch move the final bits
of specialisation into the appropriate user and softmmu helpers.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230302190846.2593720-26-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-26-richard.henderson@linaro.org>


  Commit: 2f70f2d7917357621fbc4fadeb1bb6f99bd805e0
      
https://github.com/qemu/qemu/commit/2f70f2d7917357621fbc4fadeb1bb6f99bd805e0
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/syscalls.c
    M include/gdbstub/syscalls.h

  Log Message:
  -----------
  gdbstub: Remove gdb_do_syscallv

This function is unused, except to implement gdb_do_syscall.
Fold the implementations together.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-27-richard.henderson@linaro.org>


  Commit: 0820a075af2ee1090217c59c3d8ec966907cec1c
      
https://github.com/qemu/qemu/commit/0820a075af2ee1090217c59c3d8ec966907cec1c
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/syscalls.c
    M semihosting/syscalls.c

  Log Message:
  -----------
  gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t

Pass %x as uint32_t and %lx as uint64_t; pass the address
of %s as uint64_t and the length as uint32_t.

Add casts in semihosting/syscalls.c from target_ulong to
uint64_t; add casts from int to uint32_t for clarity.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-28-richard.henderson@linaro.org>


  Commit: ad66b5cbbb9a4f92e2a4f0af5902524bbd60ee67
      
https://github.com/qemu/qemu/commit/ad66b5cbbb9a4f92e2a4f0af5902524bbd60ee67
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M stubs/meson.build
    A stubs/semihost-all.c
    M stubs/semihost.c

  Log Message:
  -----------
  stubs: split semihosting_get_target from system only stubs

As we are about to have a common syscalls.c for gdbstub we need to
stub out one semihosting helper function for all targets.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230307170405.796822-1-alex.bennee@linaro.org>


  Commit: 2d3d2517cc78763cc31da053a29786c53ccd90a2
      
https://github.com/qemu/qemu/commit/2d3d2517cc78763cc31da053a29786c53ccd90a2
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M gdbstub/meson.build
    M gdbstub/syscalls.c

  Log Message:
  -----------
  gdbstub: Build syscall.c once

There is no longer anything target specific.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-29-richard.henderson@linaro.org>


  Commit: 412ae12647d1086c713e13841fd25d10d5418c7f
      
https://github.com/qemu/qemu/commit/412ae12647d1086c713e13841fd25d10d5418c7f
  Author: Mads Ynddal <m.ynddal@samsung.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M accel/kvm/kvm-accel-ops.c
    M cpu.c
    M include/sysemu/accel-ops.h

  Log Message:
  -----------
  gdbstub: move update guest debug to accel ops

Continuing the refactor of a48e7d9e52 (gdbstub: move guest debug support
check to ops) by removing hardcoded kvm_enabled() from generic cpu.c
code, and replace it with a property of AccelOpsClass.

Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230207131721.49233-1-mads@ynddal.dk>
[AJB: add ifdef around update_guest_debug_ops, fix brace]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-27-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-30-richard.henderson@linaro.org>


  Commit: fff1aaf4451231ac680aa278e9fafc4f8b69ff57
      
https://github.com/qemu/qemu/commit/fff1aaf4451231ac680aa278e9fafc4f8b69ff57
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M pc-bios/openbios-ppc
    M pc-bios/openbios-sparc32
    M pc-bios/openbios-sparc64
    M roms/openbios

  Log Message:
  -----------
  roms/openbios: update OpenBIOS images to af97fd7a built from submodule

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: b1224d8395de9be79c8cddbc2f60d29d9f1c10fe
      
https://github.com/qemu/qemu/commit/b1224d8395de9be79c8cddbc2f60d29d9f1c10fe
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M MAINTAINERS
    M accel/kvm/kvm-accel-ops.c
    M accel/stubs/tcg-stub.c
    M accel/tcg/tb-maint.c
    M accel/tcg/translate-all.c
    M bsd-user/freebsd/os-syscall.c
    M bsd-user/main.c
    M bsd-user/signal.c
    M configure
    M cpu.c
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/meson.build
    M gdbstub/softmmu.c
    A gdbstub/syscalls.c
    M gdbstub/trace-events
    A gdbstub/user-target.c
    M gdbstub/user.c
    M hw/ppc/spapr_hcall.c
    M include/exec/cpu-defs.h
    M include/exec/exec-all.h
    M include/exec/gdbstub.h
    A include/exec/target_long.h
    A include/exec/tb-flush.h
    A include/gdbstub/helpers.h
    A include/gdbstub/syscalls.h
    A include/gdbstub/user.h
    M include/sysemu/accel-ops.h
    M linux-user/exit.c
    M linux-user/main.c
    M linux-user/signal.c
    M linux-user/user-internals.h
    M plugins/core.c
    M plugins/loader.c
    A scripts/probe-gdb-support.py
    M semihosting/arm-compat-semi.c
    M semihosting/guestfd.c
    M semihosting/syscalls.c
    M softmmu/runstate.c
    M stubs/meson.build
    A stubs/semihost-all.c
    M stubs/semihost.c
    M target/alpha/gdbstub.c
    M target/alpha/sys_helper.c
    M target/arm/gdbstub.c
    M target/arm/gdbstub64.c
    M target/arm/tcg/helper-a64.c
    M target/arm/tcg/m_helper.c
    M target/avr/gdbstub.c
    M target/cris/gdbstub.c
    M target/hexagon/gdbstub.c
    M target/hppa/gdbstub.c
    M target/i386/gdbstub.c
    M target/i386/whpx/whpx-all.c
    M target/loongarch/gdbstub.c
    M target/m68k/gdbstub.c
    M target/m68k/helper.c
    M target/m68k/m68k-semi.c
    M target/microblaze/gdbstub.c
    M target/mips/gdbstub.c
    M target/mips/tcg/sysemu/mips-semi.c
    M target/nios2/cpu.c
    M target/nios2/nios2-semi.c
    M target/openrisc/gdbstub.c
    M target/openrisc/interrupt.c
    M target/openrisc/mmu.c
    M target/ppc/cpu_init.c
    M target/ppc/gdbstub.c
    M target/riscv/csr.c
    M target/riscv/gdbstub.c
    M target/rx/gdbstub.c
    M target/s390x/gdbstub.c
    M target/s390x/helper.c
    M target/sh4/gdbstub.c
    M target/sparc/gdbstub.c
    M target/tricore/gdbstub.c
    M target/xtensa/core-dc232b.c
    M target/xtensa/core-dc233c.c
    M target/xtensa/core-de212.c
    M target/xtensa/core-de233_fpu.c
    M target/xtensa/core-dsp3400.c
    M target/xtensa/core-fsf.c
    M target/xtensa/core-lx106.c
    M target/xtensa/core-sample_controller.c
    M target/xtensa/core-test_kc705_be.c
    M target/xtensa/core-test_mmuhifi_c3.c
    M target/xtensa/gdbstub.c
    M target/xtensa/helper.c
    M target/xtensa/import_core.sh
    M tests/tcg/aarch64/Makefile.target
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/multiarch/system/Makefile.softmmu-target
    M tests/tcg/s390x/Makefile.target

  Log Message:
  -----------
  Merge tag 'pull-gdbstub-070323-3' of https://gitlab.com/stsquad/qemu into 
staging

gdbstub refactor:

  - split user and softmmu code
  - use cleaner headers for tb_flush, target_ulong
  - probe for gdb multiarch support at configure
  - make syscall handling target independent
  - add update guest debug of accel ops

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEZoWumedRZ7yvyN81+9DbCVqeKkQFAmQHomMACgkQ+9DbCVqe
# KkTtFAf/aEyKY0iUNxtB4/oV1L2VnLaZi+iKoZT4RQgrhOhzr5WV6/3/V05cw1RJ
# SIwcl8wB4gowYILs44eM/Qzcixiugl++2rvM4YVXiQyWKzkH6sY4X2iFuPGTwHLp
# y+E7RM77QNS7M9xYaVkdsQawnbsgjG67wZKbb88aaekFEn61UuDg1V2Nqa2ICy7Y
# /8yGIB2ixDfXOF0z4g8NOG44BXTDBtJbcEzf5GMz6D4HGnPZUbENy1nT0OcBk3zK
# PqKPNkPFZ360pqA9MtougjZ3xTBb7Afe9nRRMquV2RoFmkkY2otSjdPBFQu5GBlm
# NyTXEzjIQ6tCZlbS0eqdPVrUHHUx9g==
# =Al36
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 07 Mar 2023 20:45:23 GMT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* tag 'pull-gdbstub-070323-3' of https://gitlab.com/stsquad/qemu: (30 commits)
  gdbstub: move update guest debug to accel ops
  gdbstub: Build syscall.c once
  stubs: split semihosting_get_target from system only stubs
  gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t
  gdbstub: Remove gdb_do_syscallv
  gdbstub: split out softmmu/user specifics for syscall handling
  include: split target_long definition from cpu-defs
  testing: probe gdb for supported architectures ahead of time
  gdbstub: only compile gdbstub twice for whole build
  gdbstub: move syscall handling to new file
  gdbstub: move register helpers into standalone include
  gdbstub: don't use target_ulong while handling registers
  gdbstub: fix address type of gdb_set_cpu_pc
  gdbstub: specialise stub_can_reverse
  gdbstub: introduce gdb_get_max_cpus
  gdbstub: specialise target_memory_rw_debug
  gdbstub: specialise handle_query_attached
  gdbstub: abstract target specific details from gdb_put_packet_binary
  gdbstub: rationalise signal mapping in softmmu
  gdbstub: move chunks of user code into own files
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: ee59483267de29056b5b2ee2421ef3844e5c9932
      
https://github.com/qemu/qemu/commit/ee59483267de29056b5b2ee2421ef3844e5c9932
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M pc-bios/openbios-ppc
    M pc-bios/openbios-sparc32
    M pc-bios/openbios-sparc64
    M roms/openbios

  Log Message:
  -----------
  Merge tag 'qemu-openbios-20230307' of https://github.com/mcayland/qemu into 
staging

qemu-openbios queue

# -----BEGIN PGP SIGNATURE-----
#
# iQFSBAABCgA8FiEEzGIauY6CIA2RXMnEW8LFb64PMh8FAmQHzaMeHG1hcmsuY2F2
# ZS1heWxhbmRAaWxhbmRlLmNvLnVrAAoJEFvCxW+uDzIfF6oH/36gb8xmx7Pr9gj3
# QbR/ifskdvfjWXowoinaOVTBfOqEy3b3NrmbT+rG9MHZZSiMzUjYDekumrcy1vXE
# GxmhPLUGsHhKb0NWG20vwAXPVkV1Frys/35uTUdXufJqHgzasBIgZEWOLD0FiYlD
# +xrOvNlaXjiaefohke/Lzyulxiytt9Trn25tvnu+vFzufKwkT1IGg4+jqXNSYi/A
# 6f++PjEzusoK5KzxEif3F0BGauujtP/xDz2cVkg5nKmJe+cXPhWfCZWPIya6cbHZ
# vVgclmTRiPHQ8lKQM0oQfMut7s07qGoLhF8s4GUAyzLWR7s7udsmNJVphqa8AKxz
# LD8zZb0=
# =BK0K
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 07 Mar 2023 23:49:55 GMT
# gpg:                using RSA key CC621AB98E82200D915CC9C45BC2C56FAE0F321F
# gpg:                issuer "mark.cave-ayland@ilande.co.uk"
# gpg: Good signature from "Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>" 
[full]
# Primary key fingerprint: CC62 1AB9 8E82 200D 915C  C9C4 5BC2 C56F AE0F 321F

* tag 'qemu-openbios-20230307' of https://github.com/mcayland/qemu:
  roms/openbios: update OpenBIOS images to af97fd7a built from submodule

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/66a6aa8f9a56...ee59483267de



reply via email to

[Prev in Thread] Current Thread [Next in Thread]