[Qemu-commits] [qemu/qemu] ff8e48: docs/qapi-code-gen: update to cover trace events c...

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: ff8e4827adb08b3db5ee5faacf4822a7b84b91be
      
https://github.com/qemu/qemu/commit/ff8e4827adb08b3db5ee5faacf4822a7b84b91be
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M docs/devel/qapi-code-gen.rst
    M docs/devel/tracing.rst

  Log Message:
  -----------
  docs/qapi-code-gen: update to cover trace events code generation

Previous commits enabled trace events generation for most of QAPI
generated code (except for tests/ and qga/). Let's update documentation
to illustrate it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20220126161130.3240892-6-vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>


  Commit: 378dfa482d6569b0034d21931570a4f31d940301
      
https://github.com/qemu/qemu/commit/378dfa482d6569b0034d21931570a4f31d940301
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M qga/meson.build
    M tests/meson.build

  Log Message:
  -----------
  meson: document why we don't generate trace events for tests/ and qga/

Making trace generation work for tests/ and qga/ would involve some
Meson hackery to ensure we generate the trace-events files before
trace-tool uses them. Since we don't actually support tracing there
anyway, we bypass that problem.

Let's add corresponding comments.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20220126161130.3240892-7-vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Pasto fixed, commit message punctuation tidied up]
Signed-off-by: Markus Armbruster <armbru@redhat.com>


  Commit: 761a1a488e67a77858f3645a43fbdfe6208b51ce
      
https://github.com/qemu/qemu/commit/761a1a488e67a77858f3645a43fbdfe6208b51ce
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M qapi/meson.build
    M qga/meson.build
    M scripts/qapi/main.py
    M tests/meson.build

  Log Message:
  -----------
  qapi: generate trace events by default

We don't generate trace events for tests/ and qga/ because that it is
not simple and not necessary. We have corresponding comments in both
tests/meson.build and qga/meson.build.

Still to not miss possible future qapi code generation call, and not to
forget to enable trace events generation, let's enable it by default.
So, turn option --gen-trace into opposite --no-trace-events and use new
option only in tests/ and qga/ where we already have good comments why
we don't generate trace events code.

Note that this commit enables trace-events generation for qapi-gen.py
call from tests/qapi-schema/meson.build and storage-daemon/meson.build.
Still, both are kind of noop: tests/qapi-schema/ doesn't seem to
generate any QMP command code and no .trace-events files anyway,
storage-daemon/ uses common QMP command implementations and just
generate empty .trace-events

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20220126161130.3240892-8-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>


  Commit: cfe63e46be0a1f8a7fd2fd5547222f8344a43279
      
https://github.com/qemu/qemu/commit/cfe63e46be0a1f8a7fd2fd5547222f8344a43279
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M docs/devel/qapi-code-gen.rst
    M docs/devel/tracing.rst
    M meson.build
    M qapi/audio.json
    M qapi/compat.json
    M qapi/meson.build
    M qapi/replay.json
    M qapi/trace.json
    M qga/meson.build
    M scripts/qapi/commands.py
    M scripts/qapi/gen.py
    M scripts/qapi/main.py
    M tests/meson.build
    M trace/meson.build

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2022-01-27-v2' 
into staging

QAPI patches patches for 2022-01-27

# gpg: Signature made Thu 27 Jan 2022 14:19:51 GMT
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg:                 aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qapi-2022-01-27-v2:
  qapi: generate trace events by default
  meson: document why we don't generate trace events for tests/ and qga/
  docs/qapi-code-gen: update to cover trace events code generation
  meson: generate trace events for qmp commands
  qapi/commands: Optionally generate trace for QMP commands
  qapi/commands: refactor error handling code
  qapi/gen: Add FOO.trace-events output module
  schemas: add missing vim modeline

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b3a29c209e24...cfe63e46be0a