qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] d895d2: s390x: css: report errors from ccw_ds


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] d895d2: s390x: css: report errors from ccw_dstream_read/write
Date: Fri, 09 Apr 2021 09:27:05 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: d895d25ae2bb8519aa715dd2a97f09d4a66b189d
      
https://github.com/qemu/qemu/commit/d895d25ae2bb8519aa715dd2a97f09d4a66b189d
  Author: Pierre Morel <pmorel@linux.ibm.com>
  Date:   2021-04-09 (Fri, 09 Apr 2021)

  Changed paths:
    M hw/char/terminal3270.c
    M hw/s390x/3270-ccw.c
    M hw/s390x/css.c
    M hw/s390x/virtio-ccw.c

  Log Message:
  -----------
  s390x: css: report errors from ccw_dstream_read/write

ccw_dstream_read/write functions returned values are sometime
not taking into account and reported back to the upper level
of interpretation of CCW instructions.

It follows that accessing an invalid address does not trigger
a subchannel status program check to the guest as it should.

Let's test the return values of ccw_dstream_write[_buf] and
ccw_dstream_read[_buf] and report it to the caller.

Cc: qemu-stable@nongnu.org
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Message-Id: <1617899529-9329-2-git-send-email-pmorel@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 471387aa1446e2583f372f79327cc0a8c802b4b4
      
https://github.com/qemu/qemu/commit/471387aa1446e2583f372f79327cc0a8c802b4b4
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-04-09 (Fri, 09 Apr 2021)

  Changed paths:
    M hw/char/terminal3270.c
    M hw/s390x/3270-ccw.c
    M hw/s390x/css.c
    M hw/s390x/virtio-ccw.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20210409' into 
staging

One s390x fix:
- correctly handle the case where the guest ccw payload points to
  invalid memory areas

# gpg: Signature made Fri 09 Apr 2021 15:43:45 BST
# gpg:                using RSA key C3D0D66DC3624FF6A8C018CEDECF6B93C6F02FAF
# gpg:                issuer "cohuck@redhat.com"
# gpg: Good signature from "Cornelia Huck <conny@cornelia-huck.de>" [unknown]
# gpg:                 aka "Cornelia Huck <huckc@linux.vnet.ibm.com>" [full]
# gpg:                 aka "Cornelia Huck <cornelia.huck@de.ibm.com>" [full]
# gpg:                 aka "Cornelia Huck <cohuck@kernel.org>" [unknown]
# gpg:                 aka "Cornelia Huck <cohuck@redhat.com>" [unknown]
# Primary key fingerprint: C3D0 D66D C362 4FF6 A8C0  18CE DECF 6B93 C6F0 2FAF

* remotes/cohuck-gitlab/tags/s390x-20210409:
  s390x: css: report errors from ccw_dstream_read/write

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/285f6f57fa77...471387aa1446



reply via email to

[Prev in Thread] Current Thread [Next in Thread]