[Qemu-commits] [qemu/qemu] 3a129a: intc/ibex_plic: Fix some typos in the comments

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 3a129aea81f8875d510283ddef35bc614c524892
      
https://github.com/qemu/qemu/commit/3a129aea81f8875d510283ddef35bc614c524892
  Author: Alistair Francis <alistair.francis@wdc.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M hw/intc/ibex_plic.c

  Log Message:
  -----------
  intc/ibex_plic: Fix some typos in the comments

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 
22d2fb0d7af5ca316c67ac909926368d1bcb7cf5.1605136387.git.alistair.francis@wdc.com


  Commit: deef3d2568a7fbaa62d9bee07708cf3a4dc3ac53
      
https://github.com/qemu/qemu/commit/deef3d2568a7fbaa62d9bee07708cf3a4dc3ac53
  Author: Alistair Francis <alistair.francis@wdc.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M hw/intc/ibex_plic.c
    M include/hw/intc/ibex_plic.h

  Log Message:
  -----------
  intc/ibex_plic: Ensure we don't loose interrupts

If an interrupt occurs between when we claim and complete an interrupt
we currently drop the interrupt in ibex_plic_irqs_set_pending(). This
somewhat matches hardware that also ignore the interrupt between the
claim and complete process.

In the case of hardware though the physical interrupt line will still
be asserted after we have completed the interrupt. This means we will
still act on the interrupt after the complete process. In QEMU we don't
and instead we drop the interrupt as it is never recorded.

This patch changed the behaviour of the Ibex PLIC so that we save all
interrupts that occur while we are between claiming and completing an
interrupt so that we can act on them after the completition process.

This fixes interrupts being dropped when running Tock on OpenTitain in
QEMU.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 
e7bcf98c6925b1e6e7828e7c3f85293a09a65b12.1605136387.git.alistair.francis@wdc.com


  Commit: b50ea0d54bbca7d440315c3d0c0f7a4d6537b180
      
https://github.com/qemu/qemu/commit/b50ea0d54bbca7d440315c3d0c0f7a4d6537b180
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-11-14 (Sat, 14 Nov 2020)

  Changed paths:
    M hw/intc/ibex_plic.c
    M include/hw/intc/ibex_plic.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/alistair/tags/pull-riscv-to-apply-20201113-1' into staging

Two small additional fixes for the Ibex PLIC.

# gpg: Signature made Sat 14 Nov 2020 05:44:22 GMT
# gpg:                using RSA key F6C4AC46D4934868D3B8CE8F21E10D29DF977054
# gpg: Good signature from "Alistair Francis <alistair@alistair23.me>" [full]
# Primary key fingerprint: F6C4 AC46 D493 4868 D3B8  CE8F 21E1 0D29 DF97 7054

* remotes/alistair/tags/pull-riscv-to-apply-20201113-1:
  intc/ibex_plic: Ensure we don't loose interrupts
  intc/ibex_plic: Fix some typos in the comments

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/5ececc3a0b00...b50ea0d54bbc