[Qemu-commits] [qemu/qemu] 988717: virtiofsd: Remove fuse_req_getgroups

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 988717b46b6424907618cb845ace9d69062703af
      
https://github.com/qemu/qemu/commit/988717b46b6424907618cb845ace9d69062703af
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M tools/virtiofsd/fuse.h
    M tools/virtiofsd/fuse_lowlevel.c
    M tools/virtiofsd/fuse_lowlevel.h

  Log Message:
  -----------
  virtiofsd: Remove fuse_req_getgroups

Remove fuse_req_getgroups that's unused in virtiofsd; it came in
from libfuse but we don't actually use it.  It was called from
fuse_getgroups which we previously removed (but had left it's header
in).

Coverity had complained about null termination in it, but removing
it is the easiest answer.

Fixes: Coverity CID: 1413117 (String not null terminated)
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>


  Commit: 6fa249027f97e3080f3d9c0fab3f94f8f80828fe
      
https://github.com/qemu/qemu/commit/6fa249027f97e3080f3d9c0fab3f94f8f80828fe
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M tools/virtiofsd/fuse_virtio.c

  Log Message:
  -----------
  virtiofsd: fv_create_listen_socket error path socket leak

If we fail when bringing up the socket we can leak the listen_fd;
in practice the daemon will exit so it's not really a problem.

Fixes: Coverity CID 1413121
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>


  Commit: 686391112fd42c615bcc4233472887a66a9b5a4a
      
https://github.com/qemu/qemu/commit/686391112fd42c615bcc4233472887a66a9b5a4a
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M tools/virtiofsd/passthrough_ll.c

  Log Message:
  -----------
  virtiofsd: load_capng missing unlock

Missing unlock in error path.

Fixes: Covertiy CID 1413123
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>


  Commit: 99ce9a7e60fd12b213b985343ff8fcc172de59fd
      
https://github.com/qemu/qemu/commit/99ce9a7e60fd12b213b985343ff8fcc172de59fd
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M tools/virtiofsd/fuse_lowlevel.c

  Log Message:
  -----------
  virtiofsd: do_read missing NULL check

Missing a NULL check if the argument fetch fails.

Fixes: Coverity CID 1413119
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>


  Commit: 6a7e2bbee5fa5f167959f05319550d2a49a6b8bb
      
https://github.com/qemu/qemu/commit/6a7e2bbee5fa5f167959f05319550d2a49a6b8bb
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M MAINTAINERS
    M Makefile
    M docs/interop/conf.py
    M docs/interop/index.rst
    A docs/interop/virtiofsd.rst

  Log Message:
  -----------
  docs: add virtiofsd(1) man page

Document the virtiofsd(1) program and its command-line options.  This
man page is a rST conversion of the original texi documentation that I
wrote.

Reviewed-by: Liam Merwick <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: e18e5501d8ac692d32657a3e1ef545b14e72b730
      
https://github.com/qemu/qemu/commit/e18e5501d8ac692d32657a3e1ef545b14e72b730
  Author: Peter Maydell <address@hidden>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M MAINTAINERS
    M Makefile
    M docs/interop/conf.py
    M docs/interop/index.rst
    A docs/interop/virtiofsd.rst
    M tools/virtiofsd/fuse.h
    M tools/virtiofsd/fuse_lowlevel.c
    M tools/virtiofsd/fuse_lowlevel.h
    M tools/virtiofsd/fuse_virtio.c
    M tools/virtiofsd/passthrough_ll.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging

virtiofsd pull 2020-02-10

Coverity fixes and a reworked man page.

# gpg: Signature made Mon 10 Feb 2020 17:26:29 GMT
# gpg:                using RSA key 45F5C71B4A0CB7FB977A9FA90516331EBC5BFDE7
# gpg: Good signature from "Dr. David Alan Gilbert (RH2) <address@hidden>" 
[full]
# Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A  9FA9 0516 331E BC5B FDE7

* remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210:
  docs: add virtiofsd(1) man page
  virtiofsd: do_read missing NULL check
  virtiofsd: load_capng missing unlock
  virtiofsd: fv_create_listen_socket error path socket leak
  virtiofsd: Remove fuse_req_getgroups

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/81a23caf4795...e18e5501d8ac