[Qemu-commits] [qemu/qemu] f40385: target/xtensa: check zero overhead loop alignment

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f40385c959d01bf33a0e3c12ef0fdb402ad98a1c
      
https://github.com/qemu/qemu/commit/f40385c959d01bf33a0e3c12ef0fdb402ad98a1c
  Author: Max Filippov <address@hidden>
  Date:   2018-06-30 (Sat, 30 Jun 2018)

  Changed paths:
    M target/xtensa/cpu.h
    M target/xtensa/overlay_tool.h
    M target/xtensa/translate.c

  Log Message:
  -----------
  target/xtensa: check zero overhead loop alignment

ISA book documents that the first instruction of zero overhead loop
must fit completely into naturally aligned region of an instruction
fetch unit size. Check that condition and log a message if it's
violated.

Signed-off-by: Max Filippov <address@hidden>


  Commit: f3531da588b47a240a6c9f8bbd84835efed4e902
      
https://github.com/qemu/qemu/commit/f3531da588b47a240a6c9f8bbd84835efed4e902
  Author: Richard Henderson <address@hidden>
  Date:   2018-06-30 (Sat, 30 Jun 2018)

  Changed paths:
    M target/xtensa/translate.c

  Log Message:
  -----------
  target/xtensa: Replace DISAS_UPDATE with DISAS_NORETURN

The usage of DISAS_UPDATE is after noreturn helpers.
It is thus indistinguishable from DISAS_NORETURN.

Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Max Filippov <address@hidden>


  Commit: 3cc18eec0a6f22458955a718388e4b6a4d6a2d1d
      
https://github.com/qemu/qemu/commit/3cc18eec0a6f22458955a718388e4b6a4d6a2d1d
  Author: Richard Henderson <address@hidden>
  Date:   2018-06-30 (Sat, 30 Jun 2018)

  Changed paths:
    M target/xtensa/translate.c

  Log Message:
  -----------
  target/xtensa: Convert to DisasContextBase

Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Max Filippov <address@hidden>


  Commit: 1d38a7011f05e6fdc7c6bc38e4cae789b00745e3
      
https://github.com/qemu/qemu/commit/1d38a7011f05e6fdc7c6bc38e4cae789b00745e3
  Author: Richard Henderson <address@hidden>
  Date:   2018-06-30 (Sat, 30 Jun 2018)

  Changed paths:
    M target/xtensa/translate.c

  Log Message:
  -----------
  target/xtensa: Change gen_intermediate_code dc to pointer

This will reduce the size of the patch in the next patch,
where the context will have to be a pointer.

Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Max Filippov <address@hidden>


  Commit: 9c509ff94e58823624b9617590134bc05d674279
      
https://github.com/qemu/qemu/commit/9c509ff94e58823624b9617590134bc05d674279
  Author: Richard Henderson <address@hidden>
  Date:   2018-06-30 (Sat, 30 Jun 2018)

  Changed paths:
    M target/xtensa/translate.c

  Log Message:
  -----------
  target/xtensa: Convert to TranslatorOps

Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Max Filippov <address@hidden>


  Commit: 0f02251a30ea8c4ce64d9a240795e10bb3c5852c
      
https://github.com/qemu/qemu/commit/0f02251a30ea8c4ce64d9a240795e10bb3c5852c
  Author: Peter Maydell <address@hidden>
  Date:   2018-06-30 (Sat, 30 Jun 2018)

  Changed paths:
    M target/xtensa/op_helper.c

  Log Message:
  -----------
  xtensa: Avoid calling get_page_addr_code() from helper function

The xtensa frontend calls get_page_addr_code() from its
itlb_hit_test helper function. This function is really part
of the TCG core's internals, and calling it from a target
helper makes it awkward to make changes to that core code.
It also means that we don't pass the correct retaddr to
tlb_fill(), so we won't correctly handle the case where
an exception is generated.

The helper is used for the instructions IHI, IHU and IPFL.

Change it to call cpu_ldb_code_ra() instead.

Signed-off-by: Peter Maydell <address@hidden>


  Commit: 281bd281222776229d5dbf84d1a5c6d8d9d2a34b
      
https://github.com/qemu/qemu/commit/281bd281222776229d5dbf84d1a5c6d8d9d2a34b
  Author: Peter Maydell <address@hidden>
  Date:   2018-06-30 (Sat, 30 Jun 2018)

  Changed paths:
    M target/xtensa/cpu.h
    M target/xtensa/op_helper.c
    M target/xtensa/overlay_tool.h
    M target/xtensa/translate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/xtensa/tags/20180630-xtensa' into 
staging

target/xtensa updates:

- add diagnostic for zero-overhead loop alignment;
- convert to TranslatorOps;
- don't call get_page_addr_code() from helper functions.

# gpg: Signature made Sat 30 Jun 2018 22:16:30 BST
# gpg:                using RSA key 51F9CC91F83FA044
# gpg: Good signature from "Max Filippov <address@hidden>"
# gpg:                 aka "Max Filippov <address@hidden>"
# gpg:                 aka "Max Filippov <address@hidden>"
# Primary key fingerprint: 2B67 854B 98E5 327D CDEB  17D8 51F9 CC91 F83F A044

* remotes/xtensa/tags/20180630-xtensa:
  xtensa: Avoid calling get_page_addr_code() from helper function
  target/xtensa: Convert to TranslatorOps
  target/xtensa: Change gen_intermediate_code dc to pointer
  target/xtensa: Convert to DisasContextBase
  target/xtensa: Replace DISAS_UPDATE with DISAS_NORETURN
  target/xtensa: check zero overhead loop alignment

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e3800998e66c...281bd2812227
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.