[Qemu-commits] [qemu/qemu] caf316: Add maintainer for the IPMI code

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: caf316bab5d9248bb94e879f64e04249454e32d6
      
https://github.com/qemu/qemu/commit/caf316bab5d9248bb94e879f64e04249454e32d6
  Author: Corey Minyard <address@hidden>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  Add maintainer for the IPMI code

Signed-off-by: Corey Minyard <address@hidden>
Acked-by: Marc-André Lureau <address@hidden>


  Commit: 7f11cb6585d97ecdb8a657c3d8732a494e409827
      
https://github.com/qemu/qemu/commit/7f11cb6585d97ecdb8a657c3d8732a494e409827
  Author: Corey Minyard <address@hidden>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M hw/ipmi/ipmi_bmc_sim.c

  Log Message:
  -----------
  ipmi: Fix SEL get/set time commands

The minimum message size was on the wrong commands, for getting
the time it's zero and for setting the time it's 6.

Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 9f7d1d92a7adc74cb13305e0f542a030e27a3710
      
https://github.com/qemu/qemu/commit/9f7d1d92a7adc74cb13305e0f542a030e27a3710
  Author: Corey Minyard <address@hidden>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M hw/ipmi/ipmi_bmc_sim.c

  Log Message:
  -----------
  ipmi: Don't set the timestamp on add events that don't have it

According to the spec, from section "32.3 OEM SEL Record - Type
E0h-FFh", event types from 0x0e to 0xff do not have a timestamp.
So don't set it when adding those types.  This required putting
the timestamp in a temporary buffer, since it's still required
to set the last addition time.

Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>


  Commit: 9380d2ed22a5f3fa29ddf8ca4cea9bbdc88fed11
      
https://github.com/qemu/qemu/commit/9380d2ed22a5f3fa29ddf8ca4cea9bbdc88fed11
  Author: Corey Minyard <address@hidden>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M hw/ipmi/ipmi_bmc_sim.c

  Log Message:
  -----------
  ipmi: Add the platform event message command

This lets an event be added to the SEL as if a sensor had generated
it.  The OpenIPMI driver uses it for storing panic event information.

Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>


  Commit: c9c47229145e82ab7a0f27838fd74738d71fed8e
      
https://github.com/qemu/qemu/commit/c9c47229145e82ab7a0f27838fd74738d71fed8e
  Author: Corey Minyard <address@hidden>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M hw/ipmi/isa_ipmi_bt.c

  Log Message:
  -----------
  ipmi: Fix macro issues

Macro parameters should almost always have () around them when used.
llvm reported an error on this.

Remove redundant parenthesis and put parenthesis around the entire
macros with assignments in case they are used in an expression.

The macros were doing ((v) & 1) for a binary input, but that only works
if v == 0 or if v & 1.  Changed to !!(v) so they work for all values.

Remove some unused macros.

Reported in https://bugs.launchpad.net/bugs/1651167

An audit of these changes found no semantic changes; this is just
cleanups for proper style and to avoid a compiler warning.

Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 53d34b8c1ba74f14053deeb2cce7d2501695e83d
      
https://github.com/qemu/qemu/commit/53d34b8c1ba74f14053deeb2cce7d2501695e83d
  Author: Corey Minyard <address@hidden>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M hw/ipmi/ipmi_bmc_extern.c

  Log Message:
  -----------
  ipmi: disable IRQ and ATN on an external disconnect

Otherwise there's no way to clear them without an external command,
and it could lock the OS in the VM if they were stuck.

Signed-off-by: Corey Minyard <address@hidden>


  Commit: 20b233641d76cc1812064304798ffeb530dc112d
      
https://github.com/qemu/qemu/commit/20b233641d76cc1812064304798ffeb530dc112d
  Author: Corey Minyard <address@hidden>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M hw/ipmi/ipmi_bmc_sim.c

  Log Message:
  -----------
  ipmi: Allow BMC device properties to be set

Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 6a95e2586c55bddeb6439b5821a0ee5f28de4e8b
      
https://github.com/qemu/qemu/commit/6a95e2586c55bddeb6439b5821a0ee5f28de4e8b
  Author: Peter Maydell <address@hidden>
  Date:   2018-02-02 (Fri, 02 Feb 2018)

  Changed paths:
    M MAINTAINERS
    M hw/ipmi/ipmi_bmc_extern.c
    M hw/ipmi/ipmi_bmc_sim.c
    M hw/ipmi/isa_ipmi_bt.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cminyard/tags/for-release-20180201' 
into staging

Lots of litte miscellaneous fixes for the IPMI code, plus
add me as the IPMI maintainer.

# gpg: Signature made Thu 01 Feb 2018 18:44:55 GMT
# gpg:                using RSA key 61F38C90919BFF81
# gpg: Good signature from "Corey Minyard <address@hidden>"
# gpg:                 aka "Corey Minyard <address@hidden>"
# gpg:                 aka "Corey Minyard <address@hidden>"
# gpg:                 aka "Corey Minyard <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: FD0D 5CE6 7CE0 F59A 6688  2686 61F3 8C90 919B FF81

* remotes/cminyard/tags/for-release-20180201:
  ipmi: Allow BMC device properties to be set
  ipmi: disable IRQ and ATN on an external disconnect
  ipmi: Fix macro issues
  ipmi: Add the platform event message command
  ipmi: Don't set the timestamp on add events that don't have it
  ipmi: Fix SEL get/set time commands
  Add maintainer for the IPMI code

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e486b528229e...6a95e2586c55