[Qemu-commits] [qemu/qemu] ff2bc0: tpm-tis: remove unused hw

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] ff2bc0: tpm-tis: remove unused hw_access argu

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] ff2bc0: tpm-tis: remove unused hw_access argument
Date:	Fri, 20 Oct 2017 03:23:39 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ff2bc0c1159d7c1a32495cb0dbad83720554fb3d
      
https://github.com/qemu/qemu/commit/ff2bc0c1159d7c1a32495cb0dbad83720554fb3d
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: remove unused hw_access argument

This argument is always false, simplify the code.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: d8383d61fa6e11692fb8abfe0c673ece5e1ba9bb
      
https://github.com/qemu/qemu/commit/d8383d61fa6e11692fb8abfe0c673ece5e1ba9bb
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: remove RAISE_STS_IRQ

This look like temporary hacking code. It shouldn't be necessary in
release code, or there should be a runtime option for it.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 349ccdc89c1b76f6cdd9f8cdc412f0d806046d6b
      
https://github.com/qemu/qemu/commit/349ccdc89c1b76f6cdd9f8cdc412f0d806046d6b
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  tpm: make tpm_get_backend_driver() static

No need to export the function.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: f3faa1dff4dc4f3fea28ca847d57caa150c15683
      
https://github.com/qemu/qemu/commit/f3faa1dff4dc4f3fea28ca847d57caa150c15683
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M tpm.c

  Log Message:
  -----------
  tpm: lookup tpm backend class in tpm_driver_find_by_type()

One step towards removing TPMDriverOps and driver registration.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: d91a7a575e9f4e65447c6c3c094932cd13ba1167
      
https://github.com/qemu/qemu/commit/d91a7a575e9f4e65447c6c3c094932cd13ba1167
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M tpm.c

  Log Message:
  -----------
  tpm: replace tpm_get_backend_driver() to drop be_drivers

Use tpm_driver_find_by_type() instead.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: ed836d9d6bf0c89bf2e43e300fd2254237a39ef3
      
https://github.com/qemu/qemu/commit/ed836d9d6bf0c89bf2e43e300fd2254237a39ef3
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  tpm: remove tpm_register_driver()

No more users of be_drivers[], drop that too.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: cfab6da8a7d3e9d825ea284a0ebbf6579e204f74
      
https://github.com/qemu/qemu/commit/cfab6da8a7d3e9d825ea284a0ebbf6579e204f74
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_tis.h
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: move TPMSizedBuffer to tpm_tis.h

Close to where it's being used.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: d31076ba75d4239928282143efd30d08730c8845
      
https://github.com/qemu/qemu/commit/d31076ba75d4239928282143efd30d08730c8845
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M include/sysemu/tpm_backend.h
    M scripts/checkpatch.pl
    M tpm.c

  Log Message:
  -----------
  tpm: remove TPMDriverOps

Use TPMBackendClass to hold class methods/fields.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 27a79d96b42a819122c83745a5d837c9664ba915
      
https://github.com/qemu/qemu/commit/27a79d96b42a819122c83745a5d837c9664ba915
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M backends/tpm.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: remove init() class method

No backend use it.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 76ae76bfea67ca972d1158dfdea07e27e4c0852e
      
https://github.com/qemu/qemu/commit/76ae76bfea67ca972d1158dfdea07e27e4c0852e
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M tpm.c

  Log Message:
  -----------
  tpm: remove configure_tpm() hop

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 905e78ba25c613a9daa7adb4e8fb3aec0fa4a2c9
      
https://github.com/qemu/qemu/commit/905e78ba25c613a9daa7adb4e8fb3aec0fa4a2c9
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: remove unused TPMBackendCmd

There is only handling of request so far in both backends.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 54aa36d5c8ac70db25923c7a8aa11c8f7aadd225
      
https://github.com/qemu/qemu/commit/54aa36d5c8ac70db25923c7a8aa11c8f7aadd225
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c

  Log Message:
  -----------
  tpm: remove needless cast

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: d1fd6b563d44a1132f8a5758f8f7bafba548502c
      
https://github.com/qemu/qemu/commit/d1fd6b563d44a1132f8a5758f8f7bafba548502c
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: remove locty argument from receive_cb

The tpm_state is passed as argument, the assert() is pointless since
we give it the value of tpm_state->locty_number already.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 0e43b7e61ce677e154584523943c1651779baccf
      
https://github.com/qemu/qemu/commit/0e43b7e61ce677e154584523943c1651779baccf
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: add TPMBackendCmd to hold the request state

This simplifies a bit locality handling, and argument passing, and
could pave the way to queuing requests (if that makes sense).

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: c106ede9c85bf4b38c52dbee96b00c2aa0a97dee
      
https://github.com/qemu/qemu/commit/c106ede9c85bf4b38c52dbee96b00c2aa0a97dee
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_emulator.c

  Log Message:
  -----------
  tpm-emulator: fix error handling

The previous patch cleaned up a bit error handling, and exposed an
existing bug: error_report_err() could be called with a NULL error.
Instead, make tpm_emulator_set_locality() set the error.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: d2809766250d0e6b358588819c6c2e422685edfe
      
https://github.com/qemu/qemu/commit/d2809766250d0e6b358588819c6c2e422685edfe
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm: remove locty_data from TPMState

Keep it internal to tpm-tis instead.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 5086bf978445406312a4ff4127a7e2e8ac0fc655
      
https://github.com/qemu/qemu/commit/5086bf978445406312a4ff4127a7e2e8ac0fc655
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_tis.h
    M hw/tpm/tpm_util.c

  Log Message:
  -----------
  tpm-tis: move TPMState to TIS header

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 732cd5877ef07595d1d42745ef81135a27cdf3a0
      
https://github.com/qemu/qemu/commit/732cd5877ef07595d1d42745ef81135a27cdf3a0
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    R hw/tpm/tpm_tis.h

  Log Message:
  -----------
  tpm-tis: remove tpm_tis.h header

The definitions are now private to TIS implementation.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 3d4960c7addeb08513f04abaa3c52bb3c69f80f6
      
https://github.com/qemu/qemu/commit/3d4960c7addeb08513f04abaa3c52bb3c69f80f6
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: fold TPMTISEmuState in TPMState

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 698f5daa4a81984490612a6143b46f5da7392510
      
https://github.com/qemu/qemu/commit/698f5daa4a81984490612a6143b46f5da7392510
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm: add a QOM TPM interface

This will simplify backend / interface objects relationship, so the
frontend interface will simply have to implement the TPM QOM interface.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 05a699985c001927a50f8f276251f2af1e0c5b58
      
https://github.com/qemu/qemu/commit/05a699985c001927a50f8f276251f2af1e0c5b58
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: move recv_data_callback to TPM interface

Simplify the TPM backend setup, move callback to TPM interface.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: e67277f8f32d56c64c7993163f41bb4338aec566
      
https://github.com/qemu/qemu/commit/e67277f8f32d56c64c7993163f41bb4338aec566
  Author: Peter Maydell <address@hidden>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    R hw/tpm/tpm_tis.h
    M hw/tpm/tpm_util.c
    M include/sysemu/tpm_backend.h
    M scripts/checkpatch.pl
    M tpm.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stefanberger/tags/pull-tpm-2017-10-19-1' into staging

Merge tpm 2017/10/19 v1

# gpg: Signature made Thu 19 Oct 2017 16:42:39 BST
# gpg:                using RSA key 0x75AD65802A0B4211
# gpg: Good signature from "Stefan Berger <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: B818 B9CA DF90 89C2 D5CE  C66B 75AD 6580 2A0B 4211

* remotes/stefanberger/tags/pull-tpm-2017-10-19-1: (21 commits)
  tpm: move recv_data_callback to TPM interface
  tpm: add a QOM TPM interface
  tpm-tis: fold TPMTISEmuState in TPMState
  tpm-tis: remove tpm_tis.h header
  tpm-tis: move TPMState to TIS header
  tpm: remove locty_data from TPMState
  tpm-emulator: fix error handling
  tpm: add TPMBackendCmd to hold the request state
  tpm: remove locty argument from receive_cb
  tpm: remove needless cast
  tpm: remove unused TPMBackendCmd
  tpm: remove configure_tpm() hop
  tpm: remove init() class method
  tpm: remove TPMDriverOps
  tpm: move TPMSizedBuffer to tpm_tis.h
  tpm: remove tpm_register_driver()
  tpm: replace tpm_get_backend_driver() to drop be_drivers
  tpm: lookup tpm backend class in tpm_driver_find_by_type()
  tpm: make tpm_get_backend_driver() static
  tpm-tis: remove RAISE_STS_IRQ
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/840e0691303f...e67277f8f32d
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] ff2bc0: tpm-tis: remove unused hw_access argument, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 1bc6bc: Update OpenBIOS images to 83818bd built from submo...
Next by Date: [Qemu-commits] [qemu/qemu] 4b2c6b: docker: Don't allocate tty unless DEBUG=1
Previous by thread: [Qemu-commits] [qemu/qemu] 1bc6bc: Update OpenBIOS images to 83818bd built from submo...
Next by thread: [Qemu-commits] [qemu/qemu] 4b2c6b: docker: Don't allocate tty unless DEBUG=1
Index(es):
- Date
- Thread