[Qemu-commits] [qemu/qemu] 157db2: tests: Use error_free_or_abort() where appropriate

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 157db293ebf640d0ad04498ca469dcd3839a4e41
      
https://github.com/qemu/qemu/commit/157db293ebf640d0ad04498ca469dcd3839a4e41
  Author: Markus Armbruster <address@hidden>
  Date:   2017-03-15 (Wed, 15 Mar 2017)

  Changed paths:
    M tests/test-qemu-opts.c
    M tests/test-qobject-output-visitor.c

  Log Message:
  -----------
  tests: Use error_free_or_abort() where appropriate

Done with this Coccinelle semantic patch:

    @@
    expression E;
    @@
    -    g_assert(E);
    -    error_free(E);
    +    error_free_or_abort(&E);

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 4d0e72396b69656f36f484b54ffe64893d793a80
      
https://github.com/qemu/qemu/commit/4d0e72396b69656f36f484b54ffe64893d793a80
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-03-15 (Wed, 15 Mar 2017)

  Changed paths:
    M scripts/coverity-model.c

  Log Message:
  -----------
  coverity-model: model address_space_read/write

Commit eb7eeb8 ("memory: split address_space_read and
address_space_write", 2015-12-17) made address_space_rw
dispatch to one of address_space_read or address_space_write,
rather than vice versa.

For callers of address_space_read and address_space_write this
causes false positive defects when Coverity sees a length-8 write in
address_space_read and a length-4 (e.g. int*) buffer to read into.
As long as the size of the buffer is okay, this is a false positive.

Reflect the code change into the model.

Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: de71fb96bfcdf6356355f49a886fbf58fe93bf87
      
https://github.com/qemu/qemu/commit/de71fb96bfcdf6356355f49a886fbf58fe93bf87
  Author: Peter Maydell <address@hidden>
  Date:   2017-03-15 (Wed, 15 Mar 2017)

  Changed paths:
    M scripts/coverity-model.c
    M tests/test-qemu-opts.c
    M tests/test-qobject-output-visitor.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2017-03-15' into 
staging

Miscellaneous patches for 2017-03-15

# gpg: Signature made Wed 15 Mar 2017 13:12:35 GMT
# gpg:                using RSA key 0x3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-misc-2017-03-15:
  coverity-model: model address_space_read/write
  tests: Use error_free_or_abort() where appropriate

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7584bf5e6fcb...de71fb96bfcd