[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] bc35d5: io: remove mistaken call to object_re
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] bc35d5: io: remove mistaken call to object_ref on QTask |
Date: |
Wed, 03 Aug 2016 06:30:04 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: bc35d51077b33e68a0ab10a057f352747214223f
https://github.com/qemu/qemu/commit/bc35d51077b33e68a0ab10a057f352747214223f
Author: Daniel P. Berrange <address@hidden>
Date: 2016-08-03 (Wed, 03 Aug 2016)
Changed paths:
M io/channel-websock.c
Log Message:
-----------
io: remove mistaken call to object_ref on QTask
The QTask struct is just a standalone struct, not a QOM Object,
so calling object_ref() on it is not appropriate. This results
in mangling the 'destroy' field in the QTask struct, causing
the later call to qtask_free() to try to call the function
at address 0x1, with predictably segfault happy results.
There is in fact no need for ref counting with QTask, as the
call to qtask_abort() or qtask_complete() will automatically
free associated memory.
This fixes the crash shown in
https://bugs.launchpad.net/qemu/+bug/1589923
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
Commit: 0cb34ff32e3123d79daac898496ed479aede7954
https://github.com/qemu/qemu/commit/0cb34ff32e3123d79daac898496ed479aede7954
Author: Peter Maydell <address@hidden>
Date: 2016-08-03 (Wed, 03 Aug 2016)
Changed paths:
M io/channel-websock.c
Log Message:
-----------
Merge remote-tracking branch
'remotes/berrange/tags/pull-qio-next-2016-08-03-v1' into staging
Merge qio-next 2016-08-03 v1
# gpg: Signature made Wed 03 Aug 2016 10:48:08 BST
# gpg: using RSA key 0xBE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg: aka "Daniel P. Berrange <address@hidden>"
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF
* remotes/berrange/tags/pull-qio-next-2016-08-03-v1:
io: remove mistaken call to object_ref on QTask
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/90f54472f407...0cb34ff32e31
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] bc35d5: io: remove mistaken call to object_ref on QTask,
GitHub <=