[Qemu-commits] [qemu/qemu] 5614a2: add MAINTAINERS entry for qemu socket code

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5614a283a8dc48628ba2fd81c40b3fdf381f8834
      
https://github.com/qemu/qemu/commit/5614a283a8dc48628ba2fd81c40b3fdf381f8834
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  add MAINTAINERS entry for qemu socket code

Cc: Daniel P. Berrange <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden


  Commit: 505c4a1c5e00375ea552a85548f52464bd80c54a
      
https://github.com/qemu/qemu/commit/505c4a1c5e00375ea552a85548f52464bd80c54a
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M include/qemu/sockets.h
    M util/qemu-sockets.c

  Log Message:
  -----------
  sockets: remove use of QemuOpts from header file

There are no callers of the sockets methods which accept
QemuOpts any more. Make all the QemuOpts related functions
static to avoid new callers being added, in preparation
for removal of all QemuOpts usage, in favour of QAPI
SocketAddress.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1856835d6d15a7c00385a9aac7a9c3b342e16e30
      
https://github.com/qemu/qemu/commit/1856835d6d15a7c00385a9aac7a9c3b342e16e30
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M util/qemu-sockets.c

  Log Message:
  -----------
  sockets: remove use of QemuOpts from socket_listen

The socket_listen method accepts a QAPI SocketAddress object
which it then turns into QemuOpts before calling the
inet_listen_opts/unix_listen_opts helper methods. By
converting the latter to use QAPI SocketAddress directly,
the QemuOpts conversion step can be eliminated

Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2942e420e06bd6370756ef0f4722dcf8f4c74659
      
https://github.com/qemu/qemu/commit/2942e420e06bd6370756ef0f4722dcf8f4c74659
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M util/qemu-sockets.c

  Log Message:
  -----------
  sockets: remove use of QemuOpts from socket_connect

The socket_connect method accepts a QAPI SocketAddress object
which it then turns into QemuOpts before calling the
inet_connect_opts/unix_connect_opts helper methods. By
converting the latter to use QAPI SocketAddress directly,
the QemuOpts conversion step can be eliminated

Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 8b39910e631ff055b90ed50c98f5a5948b0550ed
      
https://github.com/qemu/qemu/commit/8b39910e631ff055b90ed50c98f5a5948b0550ed
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M include/qemu/sockets.h
    M util/qemu-sockets.c

  Log Message:
  -----------
  sockets: remove use of QemuOpts from socket_dgram

The socket_dgram method accepts a QAPI SocketAddress object
which it then turns into QemuOpts before calling the
inet_dgram_opts helper method. By converting the latter to
use QAPI SocketAddress directly, the QemuOpts conversion
step can be eliminated.

This removes the very last use of QemuOpts from the
sockets code, so the socket_optslist[] array is also
removed.

Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3f0230e926b45905efb597824f59fdf5a4f3da08
      
https://github.com/qemu/qemu/commit/3f0230e926b45905efb597824f59fdf5a4f3da08
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: distiguish between ipv4/ipv6 omitted vs set to off

The VNC code for interpreting QemuOpts does not currently
distinguish between ipv4/ipv6 being omitted, and being
set to 'off', because historically the 'ipv4' and 'ipv6'
options were just flags which did not accept a value.

The upshot is that if someone runs

  $QEMU -vnc localhost:1,ipv6=off

QEMU still uses PF_UNSPEC and thus may still bind to IPv6,
when it should use PF_INET.

This is another instance of the problem previously fixed
for chardevs in

  commit b77e7c8e99f9ac726c4eaa2fc3461fd886017dc0
  Author: Paolo Bonzini <address@hidden>
  Date:   Mon Oct 12 15:35:16 2015 +0200

    qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a953853ebab4b42506099156275525fc757f6c30
      
https://github.com/qemu/qemu/commit/a953853ebab4b42506099156275525fc757f6c30
  Author: Peter Maydell <address@hidden>
  Date:   2016-01-21 (Thu, 21 Jan 2016)

  Changed paths:
    M MAINTAINERS
    M include/qemu/sockets.h
    M ui/vnc.c
    M util/qemu-sockets.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-socket-20160120-1' 
into staging

Convert qemu-socket to use QAPI exclusively, update MAINTAINERS.

# gpg: Signature made Wed 20 Jan 2016 06:49:07 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-socket-20160120-1:
  vnc: distiguish between ipv4/ipv6 omitted vs set to off
  sockets: remove use of QemuOpts from socket_dgram
  sockets: remove use of QemuOpts from socket_connect
  sockets: remove use of QemuOpts from socket_listen
  sockets: remove use of QemuOpts from header file
  add MAINTAINERS entry for qemu socket code

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1cf81ea2e2ec...a953853ebab4