[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 50212d: Revert "fix return check for KVM_GET_
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 50212d: Revert "fix return check for KVM_GET_DIRTY_LOG ioc... |
Date: |
Mon, 14 Apr 2014 08:30:08 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 50212d6346f33d6e19489e81b025b5c3bb8759be
https://github.com/qemu/qemu/commit/50212d6346f33d6e19489e81b025b5c3bb8759be
Author: Michael Tokarev <address@hidden>
Date: 2014-04-14 (Mon, 14 Apr 2014)
Changed paths:
M kvm-all.c
Log Message:
-----------
Revert "fix return check for KVM_GET_DIRTY_LOG ioctl"
This reverts commit b533f658a98325d0e47b36113bd9f5bcc046fdae.
The original code was wrong, because effectively it ignored errors
from kernel, because kernel does not return -1 on error case but
returns -errno, and does not return -EPERM for this particular ioctl.
But in some cases kernel actually returned unsuccessful result,
namely, when the dirty bitmap in requested slot does not exist
it returns -ENOENT. With new code this condition becomes an
error when it shouldn't be.
Revert that patch instead of fixing it properly this late in the
release process. I disagree with this approach, but let's make
things move _somewhere_, instead of arguing endlessly whch of
the 2 proposed fixes is better.
Signed-off-by: Michael Tokarev <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 50212d: Revert "fix return check for KVM_GET_DIRTY_LOG ioc...,
GitHub <=