[Qemu-commits] [qemu/qemu] 20c334: target-mips: fix DSP overflow macro and affected r...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 20c334a797bf46a4ee59a6e42be6d5e7c3cda585
      
https://github.com/qemu/qemu/commit/20c334a797bf46a4ee59a6e42be6d5e7c3cda585
  Author: Petar Jovanovic <address@hidden>
  Date:   2013-03-04 (Mon, 04 Mar 2013)

  Changed paths:
    M target-mips/dsp_helper.c
    M tests/tcg/mips/mips32-dsp/subq_s_ph.c
    M tests/tcg/mips/mips32-dsp/subq_s_w.c

  Log Message:
  -----------
  target-mips: fix DSP overflow macro and affected routines

The previous implementation incorrectly used same macro to detect overflow
for addition and subtraction. This patch makes distinction between these
two, and creates separate macros. The affected routines are changed
accordingly.

This change also includes additions to the existing tests for SUBQ_S_PH and
SUBQ_S_W that would trigger the fixed issue, and it removes dead code from
the test file. The last test case in subq_s_w.c is a bug found/reported/
isolated by Klaus Peichl from Dolby.

Signed-off-by: Petar Jovanovic <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>